From: Lars-Peter Clausen <lars@metafoo.de>
To: Sinan Kaya <okaya@codeaurora.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Vinod Koul <vinod.koul@intel.com>,
linux-arm-msm@vger.kernel.org, timur@codeaurora.org,
linux-kernel@vger.kernel.org,
Christopher Covington <cov@codeaurora.org>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the callback
Date: Thu, 4 Aug 2016 18:15:18 +0200 [thread overview]
Message-ID: <39afe8fb-4356-b6a3-9e17-5b60abf10040@metafoo.de> (raw)
In-Reply-To: <32e4f4c5-81d1-4a84-69af-e1b05d564bd7@codeaurora.org>
On 08/04/2016 06:08 PM, Sinan Kaya wrote:
[...]
> The other way is I can feed this information to what Dave just introduced
> as part of the callback mechanism and not touch this.
Use the callback mechanism. It is a lot easier to implement correctly than
the tx_status() mechanism.
> The main discussion here is that
>
> "tx_status does not indicate whether the final transaction is successful or
> not" whether the driver has the capability to determine error or not.
tx_status() is supposed to be able to indicate whether a transfer failed or
not. But in my opinion this feature is broken by design and implementing it
correctly is very difficult without creating memory leaks. Which is probably
why so few drivers actually implement it.
next prev parent reply other threads:[~2016-08-04 16:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 2:57 Sinan Kaya
2016-07-16 1:00 ` Sinan Kaya
2016-07-24 6:24 ` Vinod Koul
2016-07-25 14:19 ` Sinan Kaya
2016-08-04 12:55 ` Vinod Koul
2016-08-04 14:17 ` Sinan Kaya
2016-08-04 14:40 ` Russell King - ARM Linux
2016-08-04 15:27 ` Sinan Kaya
2016-08-04 15:38 ` Russell King - ARM Linux
2016-08-04 15:59 ` Lars-Peter Clausen
2016-08-08 9:08 ` Vinod Koul
2016-08-08 12:25 ` Lars-Peter Clausen
2016-08-10 17:23 ` Vinod Koul
2016-08-04 16:08 ` Sinan Kaya
2016-08-04 16:15 ` Lars-Peter Clausen [this message]
2016-08-05 6:32 ` Robert Jarzmik
2016-08-05 8:34 ` Lars-Peter Clausen
2016-08-05 15:17 ` Sinan Kaya
2016-08-08 9:02 ` Vinod Koul
2016-08-08 14:45 ` Sinan Kaya
2016-08-10 17:28 ` Vinod Koul
2016-08-10 17:31 ` Sinan Kaya
2016-08-19 2:48 ` Vinod Koul
2016-08-19 3:26 ` Sinan Kaya
2016-08-19 3:42 ` Vinod Koul
2016-08-19 3:48 ` Sinan Kaya
2016-08-19 5:52 ` Vinod Koul
2016-08-19 11:13 ` okaya
2016-08-19 17:02 ` Vinod Koul
2016-08-19 17:21 ` Sinan Kaya
2016-08-22 6:08 ` Vinod Koul
2016-08-22 13:27 ` Sinan Kaya
2016-08-22 17:00 ` Vinod Koul
2016-08-08 8:51 ` Vinod Koul
2016-08-08 12:10 ` okaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39afe8fb-4356-b6a3-9e17-5b60abf10040@metafoo.de \
--to=lars@metafoo.de \
--cc=cov@codeaurora.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®