mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Myeonghun Pak <mhun512@gmail.com>
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
	Shuah Khan <shuah@kernel.org>, Hongren Zheng <i@zenithal.me>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ijae Kim <ae878000@gmail.com>,
	Michael Bommarito <michael.bommarito@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] usbip: vudc: Prevent transfer timer rearm during teardown
Date: Sat, 26 Sep 2026 13:41:05 -0600	[thread overview]
Message-ID: <3e4774b7-ef55-4288-864d-a5a9313a81c9@linuxfoundation.org> (raw)
In-Reply-To: <CAGEsz8E7TT0SqSPxpJS7QbAvAwXF8n6_ra4VPvN=q0SHdavm0A@mail.gmail.com>

On 9/24/26 15:44, Myeonghun Pak wrote:
> Hi Shuah,
> 
> __must_hold records the existing locking requirement for
> v_start_timer() and v_kick_timer(). The old comment was inaccurate
> because v_stop_timer() runs without the lock. timer_shutdown_sync() is
> the actual fix.
> 
> The QEMU harness sends CMD_SUBMIT packets while repeatedly unbinding
> and rebinding vudc. It reproduced the bug before the fix and ran 4,000
> iterations without a report afterward. I’ll add this to the v3 commit
> message.
> 
> I have not tested with physical devices and a remote client.

Please don't top-post in responses to kernel email reviews.

If you haven't tested this physical devices and a remote client, how
do you know this change fixes the problem. Sorry I can't accept this
patch.

thanks,
-- Shuah

      reply	other threads:[~2026-09-26 19:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23  2:20 Myeonghun Pak
2026-09-23  9:11 ` Shuah Khan
2026-09-24 21:44   ` Myeonghun Pak
2026-09-26 19:41     ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e4774b7-ef55-4288-864d-a5a9313a81c9@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=ae878000@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=i@zenithal.me \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mhun512@gmail.com \
    --cc=michael.bommarito@gmail.com \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®