mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: hpa@zytor.com
To: Andy Lutomirski <luto@kernel.org>,
	tedheadster@gmail.com,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Brian Gerst <brgerst@gmail.com>,
	George Spelvin <linux@horizon.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	X86 ML <x86@kernel.org>
Subject: Re: What exactly do 32-bit x86 exceptions push on the stack in the CS slot?
Date: Sun, 20 Nov 2016 20:54:12 -0800	[thread overview]
Message-ID: <4152ADD4-3F2D-46B2-B545-082C734C7640@zytor.com> (raw)
In-Reply-To: <CALCETrUqdp=rEKX4gdSpJYder3q0g_yxdRE9APw8MgerXvnB=w@mail.gmail.com>

On November 19, 2016 5:52:57 PM PST, Andy Lutomirski <luto@kernel.org> wrote:
>This is a question for the old-timers here, since I can't find
>anything resembling an answer in the SDM.
>
>Suppose an exception happens (#UD in this case, but I assume it
>doesn't really matter).  We're not in long mode, and the IDT is set up
>to deliver to a normal 32-bit kernel code segment.  We're running in
>that very same code segment when the exception hits, so no CPL change
>occurs and the TSS doesn't particularly matter.
>
>The CPU will push EFLAGS, CS, and RIP.  Here's the question: what
>happens to the high word of CS on the stack?
>
>The SDM appears to say nothing at all about this.  Modern systems
>(e.g. my laptop running in 32-bit legacy mode under KVM) appear to
>zero-extend CS.  But Matthew's 486DX appears to put garbage in the
>high bits (or maybe just leave whatever was already on the stack in
>place).
>
>Do any of you happen to know what's going on and when the behavior
>changed?  I'd like to know just how big of a problem this is.  Because
>if lots of CPUs work like Matthew's, we have lots of subtle bugs on
>them.
>
>--Andy

I believe i686+ writes zero, older CPUs leave unchanged.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

  parent reply	other threads:[~2016-11-21  5:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-20  1:52 Andy Lutomirski
2016-11-20  2:11 ` Brian Gerst
2016-11-20  2:15   ` Andy Lutomirski
2016-11-21  7:13     ` Ingo Molnar
2016-11-21 18:00       ` Linus Torvalds
2016-11-21 18:26         ` H. Peter Anvin
2016-11-21 21:21           ` Linus Torvalds
2016-11-21 22:17             ` hpa
2016-11-21 22:25               ` Linus Torvalds
2016-11-24 17:16             ` Andy Lutomirski
2016-11-22  8:30         ` Ingo Molnar
2016-11-22 17:30           ` Andy Lutomirski
2016-11-23  8:57             ` Ingo Molnar
2016-11-21  4:54 ` hpa [this message]
2016-11-21 15:58   ` H. Peter Anvin
2016-11-21 18:20     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4152ADD4-3F2D-46B2-B545-082C734C7640@zytor.com \
    --to=hpa@zytor.com \
    --cc=brgerst@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=luto@kernel.org \
    --cc=tedheadster@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®