From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F22537F015 for ; Wed, 29 Apr 2026 15:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777476397; cv=none; b=GPODMpZX+9B/2+ed/q8cZ4BSUNZhrVlXremYRH9Gf3Ycs3GNrn10p32vImFO4WFpU9nsTtw0YTu/idfd1TgWHxJQPtL/7s/m539SBE/pzjHjGjIQF9g3Pj9Ozw0hP3XUXbPmE0ysW1dadWpa207ZogRgy/EDivt1+WQOl4gT/ZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777476397; c=relaxed/simple; bh=Rg4ViyjWjJ0uH1MionkRUKz+M0sp6VZkQ9UyDJex3kw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H1UTD4EEzAcuiLovgAHC0hznDrjytAxItgFlctpmzrMATOOEDY65PtBgRl30cv6nFBkTBlO6a5kUoISU3o3eGFbB3fyufWHxjG1ixIY0DQWs/Lsq0vz+lRfxC2hlk4WQdINxG28BZQ2fDk2JgDIDzxI715Jn5IhoImpSqAkNhzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZxbT4MqG; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZxbT4MqG" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-446fea16729so1612769f8f.3 for ; Wed, 29 Apr 2026 08:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777476393; x=1778081193; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nOTrV0WGracSIFm0V666o5CRu83OUP8NlZEfiWwVSJE=; b=ZxbT4MqGYb41heJHzUNkeNrQqqbwivoko4YMr5UyQTxSL8WB1OyORAio38DxntrS6u auZrBgzdXlS/Zd+QO9j19xJeT986+p4M04JYGsA9Cy1qY7tyv6ZXSsqeu3lOu5KcvgSf bwH040Jp458XcQ78nGYH+2kcXG0HqNQhcSaQEopmU66xpyEEMarI7UgAdVTwheElzo5Z 2HR0Fn7PnbcP6s0xfsjdbr5X0o3yQ4BN/63ISgNQnvQCaJQJJrImNwWpwl1p/TSCFX2Z otPWWi2MPrnCArGZBi2AILWhP9XjXJtLKVR4fjzxCf2rtAdcaSa+MtvsIi8IVnFvQkLk 9NQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777476393; x=1778081193; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nOTrV0WGracSIFm0V666o5CRu83OUP8NlZEfiWwVSJE=; b=EWY4uWnYCqBZvPTcju31gVD07gMfGJVZsDYU5Bdk0Rp8/DBvouSgNvIQjwpY+lXPwg c5HFKs8iBqXYqfVaeHJZNOQzfXOnGKiwhN4DXEsQTzSDEoSErHuYaGsw28q7Sd+Jd3zk 7TQmqTkbXhVfR/guCVb6LhvMjyslyxBjjqqWaO733uFyGz5jxhuy+zag0rJzXGp7h1hC lnqr6+qNLtP4b+iwHDLt7P79mco9C8CdvCDaYywxBK0FvOGE3MdiPyalsr7arweeNZ6H 1CvIsKIcJLIttJbbWdXCSw0mOTgEE1+hIQxwGvnvk4zgFEuYTyLfgTrqd7osm9lOIe+1 QicA== X-Forwarded-Encrypted: i=1; AFNElJ9Q1DWDDkZ8Ezps4xwUkJwDy0htHq5nf5zyPnRbi3U5OfgJ4pW8lvA4C0kgphrmJo+8UsatKOoG/3w0gOY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxcg7Z28pK/aJjs0d21joDkkqHItRTe7M8RGW9GLeBLSxhus5MI gP/umdDyWaI471zAIvESUtBTc39uxFI2i/rQxVsI2p2bzfFSHtVuTe6e X-Gm-Gg: AeBDieucoiv84fP9cLa4PDRXQ06D/y1aU5C1reJRLYil2Ha9usbT8sdkKEC9/0pdywY poLDwUOc8LXxbVL0zeDN6nlSDOiNohL5nheaAwOTT7SwJVg1qvtDLpMxtqFyqtcO8ZahJXsIsar fEtFlsrHesytauzwS9vnZ4eHuLpI6J8Nua9FQml2YZifT2yKum36RxjYL9LxGSLfbqm5j9zVltq tjYuKz5GTnZWi338Nzl50bpZw84MabOL49Boh4xJsY2WRa3eWtTrrYk3UndKPJWOAxEFQdkCWg2 MdFwRHLwzBQbgXNCtrWYDRAA8o07tdsq69uD8wqyvqXzvwWUu7qpYAibrQbpbxfdvbBEQPaiC4g CLjaj+DcuIP4QTKBidhboyGwrpHpeDrasAYIBAaIixLC92X1g00TnjLps/iWWQjdmFt+N0Y83lG Qh6BD8lf2BQmUvZBIcljNB1E+imznMWTUVnxjSphar50qQP+SuUdNdxlmqUek33bGj/NOAxpI1m +E1phetaN9tvU88qhC13CHiF8rbpgXQfLyLjuNNA0bo X-Received: by 2002:a05:6000:250f:b0:43f:e41d:85f2 with SMTP id ffacd0b85a97d-4464839c9bcmr15101656f8f.2.1777476392719; Wed, 29 Apr 2026 08:26:32 -0700 (PDT) Received: from 127.0.0.1localhost ([82.132.184.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-447b76e5c22sm6382951f8f.28.2026.04.29.08.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 08:26:32 -0700 (PDT) From: Pavel Begunkov To: Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Cc: asml.silence@gmail.com, Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Phil Cayton , Jason Gunthorpe Subject: [PATCH v3 03/10] block: move bvec init into __bio_clone Date: Wed, 29 Apr 2026 16:25:49 +0100 Message-ID: <43a91f54d61d3329316e40c69ace781b4d35fe0b.1777475843.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To quote Cristoph: "Historically __bio_clone itself does not clone the payload, just the bio. But we got rid of the callers that want to clone a bio but not the payload long time ago". So let's move ->bi_io_vec assignment into __bio_clone(), so we have a single point where it's set. Suggested-by: Christoph Hellwig Signed-off-by: Pavel Begunkov --- block/bio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block/bio.c b/block/bio.c index 4d46af0cd256..0734b50d4992 100644 --- a/block/bio.c +++ b/block/bio.c @@ -851,6 +851,7 @@ static int __bio_clone(struct bio *bio, struct bio *bio_src, gfp_t gfp) bio->bi_write_hint = bio_src->bi_write_hint; bio->bi_write_stream = bio_src->bi_write_stream; bio->bi_iter = bio_src->bi_iter; + bio->bi_io_vec = bio_src->bi_io_vec; if (bio->bi_bdev) { if (bio->bi_bdev == bio_src->bi_bdev && @@ -893,8 +894,6 @@ struct bio *bio_alloc_clone(struct block_device *bdev, struct bio *bio_src, bio_put(bio); return NULL; } - bio->bi_io_vec = bio_src->bi_io_vec; - return bio; } EXPORT_SYMBOL(bio_alloc_clone); @@ -914,7 +913,7 @@ int bio_init_clone(struct block_device *bdev, struct bio *bio, { int ret; - bio_init(bio, bdev, bio_src->bi_io_vec, 0, bio_src->bi_opf); + bio_init(bio, bdev, NULL, 0, bio_src->bi_opf); ret = __bio_clone(bio, bio_src, gfp); if (ret) bio_uninit(bio); -- 2.53.0