From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 324943859CF for ; Wed, 8 Apr 2026 08:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775638787; cv=none; b=F45b3auJrTDO78ejgjiFaWV+lFMoD+ZxpJfqCgwMN6HOSJ0Elg5rVsaYJO94lvFpxyoDOfVMAXZOTa3WXCsvC0XjrTR4UTGDwPGxtS0jOgSedUklD6SkM1kz2DNte/Ie5kHE3HDq35s4QkBt/I980v8qKcRk2vkNmfT4gQUApRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775638787; c=relaxed/simple; bh=YR0/DSb8ieSur5/Ab19XchJDJNBVLaBOMyoDQUL3nD4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JoVpqdGv5fP8YnNiH4LRdjZkZ5F+wA0AbA90ze6/wdjqgAKy2LX6gpfX7hIapCiR+/szOiS4hWvriJcpkNrs8twOwCyC6+9fWABCaELD393OO691FmAu7kXeetaYWEIUbZ6wKf2DpOetrG0HYlO8kv9TCaxJolZ9igm2rEHo80g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=pYwk0uHf; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="pYwk0uHf" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7BEA02D95; Wed, 8 Apr 2026 01:59:38 -0700 (PDT) Received: from [10.57.19.208] (unknown [10.57.19.208]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 470753F632; Wed, 8 Apr 2026 01:59:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1775638784; bh=YR0/DSb8ieSur5/Ab19XchJDJNBVLaBOMyoDQUL3nD4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pYwk0uHfX9hwG6HoVSWfsWVI+l4EGP/KU6cdGoXHNgQrFY1iDNFWnwBXffavWVMjq MFiiKwr18685LQ0UB75Lm1WJrJUSLet6ip0eZi9T/CzYeKaKw606UPgwOnjrWZ72BP 6GeAeIfeB2eOtL4NFqQQtI6WrNLR29gB8r2ix4A0= Message-ID: <4580d6b5-9d97-40bc-ab22-a137f73d7e50@arm.com> Date: Wed, 8 Apr 2026 09:59:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/fair: Fix stale comment referencing update_cfs_shares() To: Zhan Xusheng , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Zhan Xusheng References: <20260402031301.61103-1-zhanxusheng@xiaomi.com> Content-Language: en-US From: Christian Loehle In-Reply-To: <20260402031301.61103-1-zhanxusheng@xiaomi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/2/26 04:13, Zhan Xusheng wrote: > update_cfs_shares() has been renamed to update_cfs_group(), > but some comments still refer to the old function name. > > Update these comments to reflect the current code and avoid confusion. > > Signed-off-by: Zhan Xusheng > --- > kernel/sched/fair.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index bf948db905ed..172194919c33 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -4155,7 +4155,7 @@ static inline bool cfs_rq_is_decayed(struct cfs_rq *cfs_rq) > * differential update where we store the last value we propagated. This in > * turn allows skipping updates if the differential is 'small'. > * > - * Updating tg's load_avg is necessary before update_cfs_share(). > + * Updating tg's load_avg is necessary before update_cfs_group(). > */ > static inline void update_tg_load_avg(struct cfs_rq *cfs_rq) > { > @@ -4615,7 +4615,7 @@ static void migrate_se_pelt_lag(struct sched_entity *se) {} > * The cfs_rq avg is the direct sum of all its entities (blocked and runnable) > * avg. The immediate corollary is that all (fair) tasks must be attached. > * > - * cfs_rq->avg is used for task_h_load() and update_cfs_share() for example. > + * cfs_rq->avg is used for task_h_load() and update_cfs_group() for example. > * > * Return: true if the load decayed or we removed load. > * Should mention 1ea6c46a23f1 ("sched/fair: Propagate an effective runnable_load_avg") apart from that: Reviewed-by: Christian Loehle