From: "H. Peter Anvin" <hpa@zytor.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Avi Kivity <avi@qumranet.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
caglar@pardus.org.tr
Subject: Re: [PATCH] i386: Decouple PAE from CONFIG_CMPXCHG64
Date: Wed, 18 Jul 2007 18:20:35 -0700 [thread overview]
Message-ID: <469EBC63.9020803@zytor.com> (raw)
In-Reply-To: <20070718181829.GA3848@one.firstfloor.org>
Andi Kleen wrote:
>>
>> No processors that support KVM exist that also do not support CMPXCHG64,
>> so no additional check is necessary. This setup allows for a single kernel
>> that will boot on i486 and also support KVM if available.
>
> The CONFIG should only control the early CPUID checks, which are needed for PAE
> kernels.
>
> But for something late like KVM the correct fix is really to drop
> the ifdefs around the macro and check boot_cpu_has() yourself.
>
He's checking for the appropriate functionality at runtime. What this
does is makes it impossible to select KVM when you have already selected
a CPU that doesn't support CX8.
One can, of course, question the utility, since the CPU set that
supports KVM all support CX8, but not vice versa...
-hpa
prev parent reply other threads:[~2007-07-19 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 16:34 Avi Kivity
2007-07-18 18:18 ` Andi Kleen
2007-07-19 1:20 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469EBC63.9020803@zytor.com \
--to=hpa@zytor.com \
--cc=andi@firstfloor.org \
--cc=avi@qumranet.com \
--cc=caglar@pardus.org.tr \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®