From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] dt-bindings: leds: skyworks,aat1290: Document FLINH pin
Date: Sun, 11 Oct 2026 19:35:53 +0200 [thread overview]
Message-ID: <4abc72fd-c645-4410-9387-3f03c751fd3c@gmail.com> (raw)
In-Reply-To: <CAPVz0n0FiT93626L3MnMCto1X0_FmWp_zzQpQ=yRBXn+ir6OPg@mail.gmail.com>
On 10/11/26 3:55 PM, Svyatoslav Ryhel wrote:
> нд, 11 жовт. 2026 р. о 16:28 Jacek Anaszewski <jacek.anaszewski@gmail.com> пише:
>>
>> Hi Svyatoslav,
>>
>> On 10/7/26 10:54 AM, Svyatoslav Ryhel wrote:
>>> Both the AAT1270 and AAT1290 feature a FLINH pin used for mandatory Flash
>>> inhibition.
>>>
>>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
>>> ---
>>> Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml b/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml
>>> index a65d92522c9cf..596b5e284f44a 100644
>>> --- a/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml
>>> +++ b/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml
>>> @@ -31,6 +31,10 @@ properties:
>>> maxItems: 1
>>> description: FL_EN pin
>>>
>>> + flinh-gpios:
>>> + maxItems: 1
>>> + description: FLINH pin
>>> +
>>
>> You don't seem to make use of it in your patch.
>>
>
> I don't have to use it in my patch. This change completes and improves
> hardware description of the AAT1290/1270.
Still, If we don't have the use case I'd avoid adding it to not confuse
people looking for its use in the driver.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2026-10-11 17:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 8:54 [PATCH v1 0/3] leds: aat1290: Add support for AAT1270 Svyatoslav Ryhel
2026-10-07 8:54 ` [PATCH v1 1/3] dt-bindings: leds: skyworks,aat1290: Document AAT1270 Current Regulator for Flash LEDs Svyatoslav Ryhel
2026-10-07 8:54 ` [PATCH v1 2/3] dt-bindings: leds: skyworks,aat1290: Document FLINH pin Svyatoslav Ryhel
2026-10-11 13:28 ` Jacek Anaszewski
2026-10-11 13:55 ` Svyatoslav Ryhel
2026-10-11 17:35 ` Jacek Anaszewski [this message]
2026-10-12 7:25 ` Svyatoslav Ryhel
2026-10-07 8:54 ` [PATCH v1 3/3] leds: aat1290: Add support for AAT1270 Current Regulator for Flash LEDs Svyatoslav Ryhel
2026-10-07 19:04 ` Jacek Anaszewski
2026-10-08 8:15 ` Svyatoslav Ryhel
2026-10-08 19:57 ` Jacek Anaszewski
2026-10-11 13:26 ` Jacek Anaszewski
2026-10-11 13:53 ` Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4abc72fd-c645-4410-9387-3f03c751fd3c@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®