Re: [PATCH v6 3/3] PCI: cadence: Add LGA IP debugfs for LTSSM status

[Hans Zhang <18255117159@163.com>]

On 5/20/26 13:27, Aksh Garg wrote:
> 
> 
> On 20/05/26 10:10, Hans Zhang wrote:
>>
>>
>> On 5/20/26 12:36, Aksh Garg wrote:
>>>
>>>
>>> On 20/05/26 08:29, Hans Zhang wrote:
>>>>
>>>>
>>>> On 5/20/26 10:34, Manikandan Karunakaran Pillai wrote:
>>>>>> EXTERNAL MAIL
>>>>>>
>>>>>>
>>>>>> Extend debugfs support to LGA-based Cadence PCIe controllers. The
>>>>>> 'ltssm_status' file now works for both HPA and LGA IP by selecting 
>>>>>> the
>>>>>> appropriate register access based on the 'is_hpa' flag.
>>>>>>
>>>>>> Signed-off-by: Hans Zhang <18255117159@163.com>
>>>>>> ---
>>>>>> .../controller/cadence/pcie-cadence-debugfs.c | 61 +++++++++++++++ 
>>>>>> +++-
>>>>>> .../pci/controller/cadence/pcie-cadence-ep.c  |  3 +
>>>>>> .../controller/cadence/pcie-cadence-host.c    |  9 ++-
>>>>>> drivers/pci/controller/cadence/pcie-cadence.h | 43 +++++++++++++
>>>>>> 4 files changed, 112 insertions(+), 4 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/pci/controller/cadence/pcie-cadence-debugfs.c
>>>>>> b/drivers/pci/controller/cadence/pcie-cadence-debugfs.c
>>>>>> index 97c5deef2b1a..0a308f95e9f6 100644
>>>>>> --- a/drivers/pci/controller/cadence/pcie-cadence-debugfs.c
>>>>>> +++ b/drivers/pci/controller/cadence/pcie-cadence-debugfs.c
>>>>>> @@ -13,6 +13,58 @@
>>>>>>
>>>>>> #define CDNS_DEBUGFS_BUF_MAX        128
>>>>>
>>>>> Where is CDNS_DEBUGFS_BUF_MAX used for ?
>>>>
>>>> Hi Manikandan,
>>>>
>>>> Thank you very much for your reply and reminder.
>>>>
>>>> This macro definition was used in patch 0002. Since I compiled the 
>>>> code after applying all three patches together, I didn't notice this 
>>>> issue. The next version will be fixed and will be included in patch 
>>>> 0002.
>>>
>>> I didn't understood the issue here. The macro definition was indeed 
>>> introduced in patch 0002 itself right? Am I missing something here?
>>
>> Hi Aksh,
>>
>> If only patches 0001 and 0002 are applied, there will be a compilation 
>> error. Patch 0002 will fail to find CDNS_DEBUGFS_BUF_MAX. Previously, 
>> I split LGA into patch 0003. I didn't notice this issue. Do you think 
>> I have explained it clearly?
> 
> I see no compilation errors after applying only patch 1 and 2.
> CDNS_DEBUGFS_BUF_MAX macro is defined in the patch 2 itself.
> 
> Patch 3 just uses the CDNS_DEBUGFS_BUF_MAX macro definition code for the 
> reference point to add the new code lines in that patch, it didn't 
> introduced the macro here.

Hi Aksh,

Well, I was misled. Could you please help test this series of patches? 
If there are no issues, please add your test label.

Best regards,
Hans