From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] block: fix boolreturn.cocci warning
Date: Fri, 28 Jan 2022 09:10:09 +0000 [thread overview]
Message-ID: <4c3e0a8f-5c53-6978-420c-cac0701fb0dc@nvidia.com> (raw)
In-Reply-To: <20220128043454.68927-1-jiapeng.chong@linux.alibaba.com>
On 1/27/22 8:34 PM, Jiapeng Chong wrote:
> External email: Use caution opening links or attachments
>
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> ./block/bio.c:1081:9-10: WARNING: return of 0/1 in function
> 'bio_add_folio' with return type bool.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
Good catch, looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
next prev parent reply other threads:[~2022-01-28 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 4:34 Jiapeng Chong
2022-01-28 7:43 ` Christoph Hellwig
2022-01-28 9:10 ` Chaitanya Kulkarni [this message]
2022-01-28 13:38 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2022-01-21 9:47 cgel.zte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c3e0a8f-5c53-6978-420c-cac0701fb0dc@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=abaci@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®