mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dexuan Cui <decui@microsoft.com>
To: David Miller <davem@davemloft.net>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"driverdev-devel@linuxdriverproject.org" 
	<driverdev-devel@linuxdriverproject.org>,
	"olaf@aepfle.de" <olaf@aepfle.de>,
	"apw@canonical.com" <apw@canonical.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	KY Srinivasan <kys@microsoft.com>,
	"pebolle@tiscali.nl" <pebolle@tiscali.nl>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"vkuznets@redhat.com" <vkuznets@redhat.com>,
	"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>
Subject: RE: [PATCH V4 6/7] hvsock: introduce Hyper-V VM Sockets feature
Date: Thu, 30 Jul 2015 10:17:44 +0000	[thread overview]
Message-ID: <4cd0704b1a324edc9330b11b006d8574@SIXPR30MB031.064d.mgd.msft.net> (raw)
In-Reply-To: <20150729.152737.853332463848886188.davem@davemloft.net>

> From: David Miller
> Sent: Thursday, July 30, 2015 6:28
> >From: Dexuan Cui
> >Date: Tue, 28 Jul 2015 05:35:23 -0700
> >
> > +/* hvsock_release() can be invoked in 2 paths:
> > + * 1. on process termination:
> > + *	hvsock_sk_destruct+0x1a/0x20
> > + *	__sk_free+0x1d/0x130
> > + *	sk_free+0x19/0x20
> > + *	hvsock_release+0x138/0x160
> > + *	sock_release+0x1f/0x90
> > + *	sock_close+0x12/0x20
> > + *	__fput+0xdf/0x1f0
> > + *	____fput+0xe/0x10
> > + *	task_work_run+0xd4/0xf0
> > + *	do_exit+0x334/0xb90
> > + *	? __do_page_fault+0x1e1/0x490
> > + *	? lockdep_sys_exit_thunk+0x35/0x67
> > + *	do_group_exit+0x54/0xe0
> > + *	SyS_exit_group+0x14/0x20
> > + *	system_call_fastpath+0x16/0x1b
> > + *
> > + *  2. when accept() returns -ENITR:
> > + *	hvsock_release+0x151/0x160
> > + *	sock_release+0x1f/0x90
> > + *	sock_close+0x12/0x20
> > + *	__fput+0xdf/0x1f0
> > + *	____fput+0xe/0x10
> > + *	task_work_run+0xb7/0xf0
> > + *	get_signal+0x750/0x770
> > + *	do_signal+0x28/0xbb0
> > + *	? put_unused_fd+0x52/0x60
> > + *	? SYSC_accept4+0x1ca/0x220
> > + *	do_notify_resume+0x4f/0x90
> > + *	int_signal+0x12/0x17
> > + */
> 
> It is a bit much to put full stack backtraces into a comment like this.

Thanks for reviewing the patch, David!
I'll remove these lines and add a proper comment here.

Thanks,
-- Dexuan

      reply	other threads:[~2015-07-30 10:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 12:35 Dexuan Cui
2015-07-29 22:27 ` David Miller
2015-07-30 10:17   ` Dexuan Cui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cd0704b1a324edc9330b11b006d8574@SIXPR30MB031.064d.mgd.msft.net \
    --to=decui@microsoft.com \
    --cc=apw@canonical.com \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=pebolle@tiscali.nl \
    --cc=stefanha@redhat.com \
    --cc=stephen@networkplumber.org \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®