From: Atish Patra <atish.patra@wdc.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "palmer@sifive.com" <palmer@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"robh@kernel.org" <robh@kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
"anup@brainfault.org" <anup@brainfault.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [RFC 2/3] RISC-V:Support per-hart timebase-frequency
Date: Mon, 17 Sep 2018 19:23:02 -0700 [thread overview]
Message-ID: <4d7c1d3d-df0b-df7c-aabd-8ce9fd9dc623@wdc.com> (raw)
In-Reply-To: <20180917142308.GB15588@infradead.org>
On 9/17/18 7:23 AM, Christoph Hellwig wrote:
> On Fri, Sep 14, 2018 at 02:54:55PM -0700, Atish Patra wrote:
>> Follow the updated DT specs and read the timebase-frequency
>> from the boot cpu. Keep the old DT reading as well for backward
>> compatibility. This patch is rework of old patch from Palmer.
>>
>> Signed-off-by: Atish Patra <atish.patra@wdc.com>
>
> This setup looks a bit odd because it keeps blindly overwriting
> riscv_timebase for every cpu found. Shouldn't we at least check that
> they all match for now as the rest of the port assumes that?
>
It will be only updated for boot cpu as it is done after this check.
if (cpuid != smp_processor_id())
return 0;
Regards,
Atish
next prev parent reply other threads:[~2018-09-18 2:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 21:54 [RFC 0/3] Timer code cleanup Atish Patra
2018-09-14 21:54 ` [RFC 1/3] dt-bindings: Correct RISC-V's timebase-frequency Atish Patra
2018-09-17 14:20 ` Christoph Hellwig
2018-09-18 2:26 ` Atish Patra
2018-09-14 21:54 ` [RFC 2/3] RISC-V:Support per-hart timebase-frequency Atish Patra
2018-09-17 14:23 ` Christoph Hellwig
2018-09-18 2:23 ` Atish Patra [this message]
2018-09-29 0:20 ` Palmer Dabbelt
2018-09-14 21:54 ` [RFC 3/3] RISC-V: Remove per cpu clocksource Atish Patra
2018-09-17 14:35 ` Christoph Hellwig
2018-09-17 14:52 ` Thomas Gleixner
2018-09-17 15:01 ` Christoph Hellwig
2018-09-17 15:04 ` Thomas Gleixner
2018-09-17 15:54 ` Anup Patel
2018-09-17 18:32 ` Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d7c1d3d-df0b-df7c-aabd-8ce9fd9dc623@wdc.com \
--to=atish.patra@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=anup@brainfault.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®