From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010048.outbound.protection.outlook.com [52.101.46.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CC132EB84E for ; Thu, 14 May 2026 07:32:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.48 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778743944; cv=fail; b=LY88qG47W8p/AKgtbl+FkLAaQ7rt/9ZhdfEs70lUjbrfdDXbhbklM5Qlk+w6xcXeJ6tajFMJGQiijt4AzGB2IbNhB8c4PWsHdyb92c4kspsZDdXF3qPq8TcX1v/+AFEvh9bDYTYSVxkX+Wzzi2EiBu6YDeGqsYkeZJ3A4SVmLhc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778743944; c=relaxed/simple; bh=CFlJktPkLh6Ykqnjtd/dxHd6xe3DcIXhxtUfkU5wjew=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=inNrCIrK8EB+CNhxoWbMx0Fil2o0DjhTCcU1avfZ6PjVjgKyCMmC1VcxVJZ3jr9vtqpIzmzaXFOxXhOpHvjkmmu4t8bipSoGofKKurfxe00CgyrO7HW5zpUu97FsnRASqP2fUrthW9FwsF6rXUooWIQT+10jJjcJ2wartugrupE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=h1jBlolR; arc=fail smtp.client-ip=52.101.46.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="h1jBlolR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qjrFuUIpPUoow5569I6wvWpwjJrN0P/QjaIqndHkl71OyA9TknAXqOb+U982b+MaJebspgVoKH2zoWBzWmfIWiajgFq6QAMdvz1vDp6SyhVyAwhjCaTQlIaFOBTQbyGVGOyiTOIYcObMxa/6gLJ074aD8SQx6DiNWppUYjXDuL5p6oluUdu09w6355jsUx/M2k7sw5EtHedw9KwjBZqSehsIaGYp/X+8yaApz8ii4HRnPFox87Gfdm/fyauKVHKAElL71UshxmP9ZvXu3zCKqwpe+82IyLrceNWOEaH4TMzd+nLzrrDN1GTYF+x5BTn9+V/GCOoLPGVGQLvKUWXUfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L9ZdfKwcP53MQ8OTz3EwVTY+N9qHh0PKPLItUTm40u4=; b=yDMmO1fbsrZIZl+MDzIT/OG/5t7dDMPhZUity1PV/+pTByVAxS9JWL1k3ZxN8784PZ3C+ETpEg0O1/r1Ne70mXlQlyxoATmH+/EAEsT4wSAICP67tZyx1jxW5UcewFH/gEm94VMLkNDEpopP4mATnqE7Of7gi5WpoAv44YAerFX+kAZT2O8xhYQZcRbfyAI9/qxdlr75iN+YiDj49LGYRhqy/AQcZz7XoCfJfAq8wTKIub4WH76V8lkY54tQEYzF3fIDRAKV21YjiIzzHZ2SyI/b2oAOrVukzpheAXX5cBUTUtlfbVVcI/jx2+Kz7EAo8iiXONstCtRDavo+9WNuMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L9ZdfKwcP53MQ8OTz3EwVTY+N9qHh0PKPLItUTm40u4=; b=h1jBlolRzd1GtkJecY4YZ0iycj8+f+K4MH4hcChbgY3yMbrgQAxaHXPu4d9a1IHxHWvVuv+2L6PIGz291Kcdzo+/lLkyPrMzuJRfXTaHvBvtOZc+e/Ui7zI3/b4GB2jl0Oh5Csmt/UNjZ0TY3tpCIVPWJtUep+Cr3xZ6+tKZXtlame8Elrp8jhe0DkriF1+JlMifYZhN6Ap+Delt6k57Fc1O/RzZjKO+KRZl7SQnY8Vhuct4Qrcqjv0Kkr6ecAiMymvHDUPmFx5uiV+2IUgClb+oUickuw4WRzDuUxszo9TK38wVrB43Nhwo1NVKFGatVuqzww11JxuMEhOvhn2DkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from SJ0PR03MB5950.namprd03.prod.outlook.com (2603:10b6:a03:2d3::20) by CH0PR03MB6177.namprd03.prod.outlook.com (2603:10b6:610:d0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9913.11; Thu, 14 May 2026 07:32:21 +0000 Received: from SJ0PR03MB5950.namprd03.prod.outlook.com ([fe80::53a0:bf93:6b6b:de01]) by SJ0PR03MB5950.namprd03.prod.outlook.com ([fe80::53a0:bf93:6b6b:de01%4]) with mapi id 15.20.9913.009; Thu, 14 May 2026 07:32:21 +0000 From: tze.yee.ng@altera.com To: Dinh Nguyen , linux-kernel@vger.kernel.org Cc: Tze Yee Ng , Adrian Ng Ho Yin , Nazim Amirul Subject: [PATCH 3/3] Fixes: 15847537b623 ("firmware: stratix10-rsu: Migrate RSU driver to use stratix10 asynchronous framework.") Date: Thu, 14 May 2026 00:32:18 -0700 Message-ID: <540176c3e715fd573f2d3d404f45ece202e3734d.1778742913.git.tze.yee.ng@altera.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: References: Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BY5PR20CA0026.namprd20.prod.outlook.com (2603:10b6:a03:1f4::39) To SJ0PR03MB5950.namprd03.prod.outlook.com (2603:10b6:a03:2d3::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB5950:EE_|CH0PR03MB6177:EE_ X-MS-Office365-Filtering-Correlation-Id: cc908e29-d792-4ba8-6544-08deb18aef79 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|55112099003|11063799003|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: KbWTo2cSAMdh8IuCHTKI9yhco8OJFtZm4ncgGsd5NykY4vuRbbTSO/nAQHOKr/+vmyyaM54XW6R+E28G/L4ARd7AEDs6pnKZ0Kdbh3TpFrfsrIr/k/Uz1Njxle/NOTWC5S7t80I3PeGpCumz0bAc1UMMjmVRyUUYrRDtXcBdhPTZJHxH6X3zSF7D9aQl8O0ezQiNhiu/cEC7OHkbbJ0GIB5U+Ic/tru+7EYKZvZ5ken+rekRz7mWZ6Sme3/rw9GKVX7829Qoz2h7TlsnAA92Gx2jQhRrKvN64cm8s0vbH4lhZZFqTx/M5YTK3227nlbBg8TlA3xGOnD9aAGJa+Se9i2kafaeXaGvkKEDuJkLjywC+cOt0eaqzpYnVSvkKCUWJFYKJxx/RMDFBx9b7uQBgAR+mqmvI8acLFPSO998ZIYqPPtkJYaJ3bI6W5XfNcyQYsTwJOi6CJm67xsaFva+C+iOA0iPRZVfhAAAfWRI32InGUZw9owpvXsadbw8GDoVBD2nTl9nDRRfIILTchb9A51xcWI385iAV5pW1BHQZ9J8mR4ucRp74tnmShucOIiNJPMoW7pY9msbg1YZmTjnszYfbHaDjp+k8e/buJHSbG2+6R0o7vv6dQ959h+6DSwp9LoPi0HH3Si/h53atT4ngi3rdMy15CN7zWricq842PrsgUk/iPOdU5Gpc/hei7s7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5950.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(55112099003)(11063799003)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yrlmRsYb9xELbrZu8Dsl/DklImIb5dfGpFj0HRobdwe0KMYiQnWEH/uecs39?= =?us-ascii?Q?1MicpM9L/HrzKBdixoLb1fYYBG0t6fF/3+RkJ8o5WblFPhQ0cBpjoQUJfUdB?= =?us-ascii?Q?XX0WahrjwU+WH6bZ37PImtMZKijq0hJ9RiRgwzPsk7t3iQtE1w5BDNwvpGXX?= =?us-ascii?Q?HsgtJQMk5DRBLKWxvVm7LZ6bnSbvt1YqUiSgZ1H6tmCjtPdTUrfZQnqJ05oY?= =?us-ascii?Q?Lc28tLbOvUH6H718Tiil4xlEjgipjdH1VhP+CNcZU5+MzAZFtp3wqYQMFyPT?= =?us-ascii?Q?duDxh9Ei8piPMon2E+QDpLYai3b1Qbkzy8PA90DVXwLXWxltrU6ei/uX2n+L?= =?us-ascii?Q?8O+Kb6T4UsOoFROx4AcbumI6f999649wAiOuDvDQMyneEKX2BSs+XQLZ4Lhi?= =?us-ascii?Q?fae9oR2rKVSaNC4DX5uJ80/LpUOSxxbMcuNxD9lwGYQsA4SSvoG5YXIJW8zP?= =?us-ascii?Q?4b61vLPFviytvg+qqeSKMXTlBxHfSHFiRQBhjW9Z/N6dVsgHKSXqhAuaJs+M?= =?us-ascii?Q?2LFwta6zaLIiW+HjpXuDWFh6+ivdbeelDMB+hqouiZdoOpwpyK+bb3bUqTVP?= =?us-ascii?Q?j2BHCPfXA1betV7qvSKx41gu6Ia+A2dbwixQs4E9TjieX6B4atDfCaUJqHeh?= =?us-ascii?Q?CIaCg3suE2HiqvLq9wAL2NVGKc7dolWkQm4z7wq7Nltq9YGQ/bfcfB3IxUSn?= =?us-ascii?Q?RY8vyupb4RbSlQT+1/XsMhAHd9f7e6aSuzpPX5sUPMN2llu803qv89G78ZFA?= =?us-ascii?Q?oxwRL0dP5iEp/PcWfFphg34y6fgsWNudk/0KVEpKjnuaRvGfX9bHDdGcvmoR?= =?us-ascii?Q?mWiBC35pUyVMRw2F/Sl485WWI+0w//oOPAcZaXWMoee/Oe9clP6p3kmuuhhs?= =?us-ascii?Q?eAgR4vdwNjKIW7aaU9haXKTahl42CXQZiDPukU7FGbpzkw3Mmj8+GQB1hdhI?= =?us-ascii?Q?IPzeQEDbQyUUL3zk0Lur1BHJKlgSI8BKLuVMRT+ZwA7pW80yVPTcO0KojoE+?= =?us-ascii?Q?gjbkDAD2rhnFMOmUYVBu/jfNm+Wl8q9BtLvd1JpxYMxkbUX4yUcmswiCXc1j?= =?us-ascii?Q?EWLwyebxHOpYkHm0E6LczmO5YHfouCU1ZqgIbnrksJ102Abgt3gJq6kqtl4F?= =?us-ascii?Q?g+BD5RuxeNR6VWVy+E8YZZhbY4BNkQBvdZBMH6x+ZiRUlhriPS4oLDl/4cdO?= =?us-ascii?Q?XtJkI+ULBVfVSF4F0Qy1J7Ze4qHAW8xfz79PMezBfC+BfAFAOUZm48KUqfBx?= =?us-ascii?Q?Ks5Ty/855O3eygiHGN8H7eEFdFES8T9/UcR1Y26Rw356Zaf4OBIiQ+qvx4oW?= =?us-ascii?Q?xUZ8U1GlqDiFZDhO1sAf0B6pZUjalaxwQawoe4wV8XWUq98aThZh6joYVWEF?= =?us-ascii?Q?L7Qd34TTdAyDR0TaUyWZfEB1XoPz2Z3gas2WEsbJEUxogGh4pT1Z8JjOxMn8?= =?us-ascii?Q?hCfaIZi8N63JQHMzm6inHnPwvAy4MAtit6JYxL60ppULybf2lch616M7yZOm?= =?us-ascii?Q?ujvbQVV4br1YJLcmaqxEzs/oTPRuTw8PX3Alu/7EHRufC8mAaY5tptg4j4P3?= =?us-ascii?Q?FShc5Cue4DTjPNKTY0X4p3qHZL7KUwi4PxLY36ZDYwPPz0Q+RASIFn4YzPc0?= =?us-ascii?Q?n6edOjoBTgJrectJrKsBU5VFrdrQEBZLjvDYhowHXZs5hvuhJupKroqhARuJ?= =?us-ascii?Q?MQaJN+FtrPM/aOgTsAiINag3d7wqIODU7aAKjPZ105NgfmXXOGB8mGqaxkIi?= =?us-ascii?Q?S1iZ1/ZPcw=3D=3D?= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc908e29-d792-4ba8-6544-08deb18aef79 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5950.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2026 07:32:21.5983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mQZIKrgcZEzObhwe0pu6bQBV0RIDyrxTlWcDckP94tDrdh00aneUN1Qm/7tDL70YY+yuCnpZKOYSZeTZk/711Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6177 From: Tze Yee Ng After stratix10_svc_add_async_client() succeeds, probe error paths and remove() must call stratix10_svc_remove_async_client() before stratix10_svc_free_channel(). Otherwise async state is left allocated while the channel is released. Signed-off-by: Tze Yee Ng --- drivers/firmware/stratix10-rsu.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/stratix10-rsu.c b/drivers/firmware/stratix10-rsu.c index 6c5f952f48d8..a0f679f73460 100644 --- a/drivers/firmware/stratix10-rsu.c +++ b/drivers/firmware/stratix10-rsu.c @@ -958,21 +958,27 @@ static int stratix10_rsu_probe(struct platform_device *pdev) 0, rsu_dcmf_version_callback); if (ret) { dev_err(dev, "Error, getting DCMF version %i\n", ret); + stratix10_svc_remove_async_client(priv->chan); stratix10_svc_free_channel(priv->chan); + return ret; } ret = rsu_send_msg(priv, COMMAND_RSU_DCMF_STATUS, 0, rsu_dcmf_status_callback); if (ret) { dev_err(dev, "Error, getting DCMF status %i\n", ret); + stratix10_svc_remove_async_client(priv->chan); stratix10_svc_free_channel(priv->chan); + return ret; } ret = rsu_send_msg(priv, COMMAND_RSU_MAX_RETRY, 0, rsu_max_retry_callback); if (ret) { dev_err(dev, "Error, getting RSU max retry %i\n", ret); + stratix10_svc_remove_async_client(priv->chan); stratix10_svc_free_channel(priv->chan); + return ret; } /* get QSPI device info from firmware */ @@ -989,16 +995,19 @@ static int stratix10_rsu_probe(struct platform_device *pdev) rsu_async_get_spt_table_callback); if (ret) { dev_err(dev, "Error, getting SPT table %i\n", ret); + stratix10_svc_remove_async_client(priv->chan); stratix10_svc_free_channel(priv->chan); + return ret; } - return ret; + return 0; } static void stratix10_rsu_remove(struct platform_device *pdev) { struct stratix10_rsu_priv *priv = platform_get_drvdata(pdev); + stratix10_svc_remove_async_client(priv->chan); stratix10_svc_free_channel(priv->chan); } -- 2.43.7