From: "Ouyangzhaowei (Charles)" <ouyangzhaowei@huawei.com>
To: <david.vrabel@citrix.com>
Cc: <linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org>,
"Zhaojun (Euler)" <zhao.zhaojun@huawei.com>, <jinjian@huawei.com>,
<boris.ostrovsky@oracle.com>, <konrad.wilk@oracle.com>
Subject: patch about "don't reset vcpu_info on a cancelled suspend"
Date: Tue, 29 Dec 2015 13:49:54 +0800 [thread overview]
Message-ID: <56821F02.6050209@huawei.com> (raw)
Hi David,
This patch has been applied to for-linus-4.1b, and we wonder if this patch will be applied to linux kernel, or does
it still needs more test to apply to linux kernel?
thanks
On 2015.5.28 19:07, David Vrabel wrote:
>> vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu
>>
>> The hypervisor continues assuming that vcpu_info is stored in per-cpu data which was set up by xen_vcpu_setup(),
>> while on canceled suspend, the call to xen_hvm_init_shared_info() will make the guest think that vcpu_info
>> is in the shared page. This will cause non-boot cpus keep checking a wrong vcpu_info address and can not handle
>> irqs any more after suspend canceled, for example after we do "xl save -c/restore", PVOPS VM can not be resumed
>> as the cpus can not finish their irqs.
>>
>>
>> Signed-off-by: Charles Ouyang <ouyangzhaowei [at] huawei>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky [at] oracle>
>> Reviewed-by: David Vrabel <david.vrabel [at] citrix>
>
> 1. I don't think I offered a reviewed-by tag for this patch
> 2. You did not Cc the xen-devel mailing list on this patch.
> 3. The patch is white-space damaged.
> 4. The commit message has lines longer than ~72 chars.
>
> But I've applied this to for-linus-4.1b anyway, thanks.
>
> David
next reply other threads:[~2015-12-29 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 5:49 Ouyangzhaowei (Charles) [this message]
2016-01-04 11:54 ` [Xen-devel] " David Vrabel
2016-01-07 1:43 ` Ouyangzhaowei (Charles)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56821F02.6050209@huawei.com \
--to=ouyangzhaowei@huawei.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jinjian@huawei.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=zhao.zhaojun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®