From: Damon Ding <damon.ding@rock-chips.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Jessica Zhang <jesszhan0024@gmail.com>,
Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>,
Lucas Stach <l.stach@pengutronix.de>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Paul Kocialkowski <paulk@sys-base.io>,
Linus Walleij <linusw@kernel.org>,
Inki Dae <inki.dae@samsung.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sean Paul <sean@poorly.run>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>
Cc: Albert Esteve <aesteve@redhat.com>,
Anusha Srivatsa <asrivats@redhat.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Hui Pu <Hui.Pu@gehealthcare.com>,
Ian Ray <ian.ray@gehealthcare.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-mips@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com, asahi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH v3 19/19] drm/bridge: analogix_dp: don't create a panel_bridge
Date: Tue, 22 Sep 2026 16:54:03 +0800 [thread overview]
Message-ID: <5a411d61-18f4-4d12-9acf-78320ab97d6b@rock-chips.com> (raw)
In-Reply-To: <DLLOW2ROGP6L.3GTVT76VYPGAU@bootlin.com>
On 9/22/2026 4:07 PM, Luca Ceresoli wrote:
> Hello Damon,
>
> On Mon Sep 21, 2026 at 8:34 AM CEST, Damon Ding wrote:
>> On 9/21/2026 11:07 AM, Damon Ding wrote:
>>> Hi Luca,
>>>
>>> On 9/16/2026 9:45 PM, Luca Ceresoli wrote:
>>>> Now a panel_bridge is automatically created for every drm_panel and the
>>>> panel-bridge API is just a deprecated wrapper to access it.
>>>>
>>>> Update and simplify the code by just getting a reference to the
>>>> already-existing bridge using of_drm_get_bridge_by_endpoint().
>>>>
>>>> As of_drm_get_bridge_by_endpoint() returns a refcounted bridge, take care
>>>> of putting the bridge reference. This is not easily done in the remove
>>>> path
>>>> due to the different probe paths of the user drivers, so add a devm
>>>> action
>>>> to ensure the reference is put only when it was taken.
>>>>
>>>> Assisted-by: opencode:deepseek-v4-flash-0731
>>>> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>>>> ---
>>>> drivers/gpu/drm/bridge/analogix/Kconfig | 1 -
>>>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 40 ++++++++++++
>>>> +---------
>>>> drivers/gpu/drm/exynos/exynos_dp.c | 36 +
>>>> +-----------------
>>>> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 9 -----
>>>> include/drm/bridge/analogix_dp.h | 1 -
>>>> 5 files changed, 25 insertions(+), 62 deletions(-)
>>>>
>>
>> [snip]
>>
>>>> @@ -488,14 +487,6 @@ static void rockchip_dp_remove(struct
>>>> platform_device *pdev)
>>>> {
>>>> struct rockchip_dp_device *dp = platform_get_drvdata(pdev);
>>
>> The above unused &rockchip_dp_device could be also remved.
>
> Ah, indeed!
>
> I guess I can keep your review tags if applying this patch with only this
> line removed. Correct?
>
Yeah, sure!
Best regards,
Damon
next prev parent reply other threads:[~2026-09-22 8:59 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 13:45 [PATCH v3 00/19] drm/panel: embed a drm_bridge into every drm_panel Luca Ceresoli
2026-09-16 13:45 ` [PATCH v3 01/19] drm: of: move drm_of_find_panel_or_bridge() from drm_of.c to drm_panel.c Luca Ceresoli
2026-09-21 15:06 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 02/19] drm: of: remove now unnecessary forward declarations Luca Ceresoli
2026-09-21 15:06 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 03/19] drm/panel: move to a new module Luca Ceresoli
2026-09-16 13:45 ` [PATCH v3 04/19] drm/bridge: panel: move all code to drm_panel.c Luca Ceresoli
2026-09-21 15:08 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 05/19] drm/panel: embed a drm_bridge into every drm_panel Luca Ceresoli
2026-09-22 6:56 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 06/19] drm/bridge: remove devm_drm_put_bridge() Luca Ceresoli
2026-09-22 6:57 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 07/19] drm/panel: deprecate panel-bridge APIs Luca Ceresoli
2026-09-22 6:57 ` Maxime Ripard
2026-10-01 6:59 ` Linus Walleij
2026-09-16 13:45 ` [PATCH v3 08/19] drm/todo: add entry for removing the panel_bridge API Luca Ceresoli
2026-09-22 6:58 ` Maxime Ripard
2026-10-01 6:59 ` Linus Walleij
2026-09-16 13:45 ` [PATCH v3 09/19] drm/bridge: tc358767: don't create a panel_bridge Luca Ceresoli
2026-09-22 6:59 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 10/19] drm/bridge: waveshare-dsi: " Luca Ceresoli
2026-09-22 6:59 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 11/19] drm/mcde: dsi: remove unused includes Luca Ceresoli
2026-09-20 22:26 ` Linus Walleij
2026-09-22 6:59 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 12/19] drm/mcde: dsi: don't create a panel_bridge Luca Ceresoli
2026-09-20 22:26 ` Linus Walleij
2026-09-22 7:09 ` Maxime Ripard
2026-09-24 7:01 ` Luca Ceresoli
2026-09-24 7:51 ` Linus Walleij
2026-09-24 8:57 ` Maxime Ripard
2026-09-25 16:25 ` Linus Walleij
2026-09-25 16:33 ` Luca Ceresoli
2026-09-26 15:14 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 13/19] drm/bridge: fsl-ldb: " Luca Ceresoli
2026-09-21 14:22 ` Laurentiu Palcu
2026-09-22 7:09 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 14/19] drm/bridge: samsung-dsim: " Luca Ceresoli
2026-09-22 7:10 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 15/19] drm/bridge: tc358768: " Luca Ceresoli
2026-09-22 7:10 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 16/19] drm/bridge: ssd2825: " Luca Ceresoli
2026-09-22 7:21 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 17/19] drm/omap: dss: " Luca Ceresoli
2026-09-22 7:21 ` Maxime Ripard
2026-09-16 13:45 ` [PATCH v3 18/19] drm/tve200: " Luca Ceresoli
2026-09-17 15:14 ` Luca Ceresoli
2026-09-22 7:28 ` Maxime Ripard
2026-10-01 7:00 ` Linus Walleij
2026-09-16 13:45 ` [PATCH v3 19/19] drm/bridge: analogix_dp: " Luca Ceresoli
2026-09-21 3:07 ` Damon Ding
2026-09-21 6:34 ` Damon Ding
2026-09-22 8:07 ` Luca Ceresoli
2026-09-22 8:54 ` Damon Ding [this message]
2026-09-22 8:12 ` Luca Ceresoli
2026-09-22 8:22 ` Heiko Stuebner
2026-09-22 8:57 ` Damon Ding
2026-09-28 8:48 ` [PATCH v3 00/19] drm/panel: embed a drm_bridge into every drm_panel Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a411d61-18f4-4d12-9acf-78320ab97d6b@rock-chips.com \
--to=damon.ding@rock-chips.com \
--cc=Frank.Li@nxp.com \
--cc=Hui.Pu@gehealthcare.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=aesteve@redhat.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=asahi@lists.linux.dev \
--cc=asrivats@redhat.com \
--cc=corbet@lwn.net \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=freedreno@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=ian.ray@gehealthcare.com \
--cc=imx@lists.linux.dev \
--cc=inki.dae@samsung.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jesszhan0024@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=laurentiu.palcu@oss.nxp.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=paul@crapouillou.net \
--cc=paulk@sys-base.io \
--cc=rdunlap@infradead.org \
--cc=rfoss@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=skhan@linuxfoundation.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®