From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 768AF34752F for ; Mon, 13 Jul 2026 07:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783927103; cv=none; b=ZvZae5dWXI7gmAOddngnsD7yAQEXR6HTmQ4qEBSxENxEQz0rmpPWH7qj1CEi2+0cYhBhdNxV/sS26NPEjrYH8Ii3HwB8QujVXw0i5sTdpxA7r9Um8whs+CIW6cXpiS5P0JcJvB3SiIT88GOTJjGpAybrKSgW947lfEGmNUZOCa8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783927103; c=relaxed/simple; bh=ib4LwCcs0y+YPV1sCdGS4y+acMyB3HbnzG4R5yTs7g4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kSDkUgL6Z41u+npE61rnHjUg0tbo2aeeeBUeaNFksOkD/8xhmmjbxpDlhSln98N4BqmYG8LtdZuZV+H9vOQdcJLzJrD+PnQVDDKk7uFC4R0luzFQ9vsHgVftomWCV0QnrBcZRXaV4fviT8vpG8UKRbLV2f6wSUQLM/np/iRbcUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Z5XOpG9m; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=lmuMvv1Y; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Z5XOpG9m; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=lmuMvv1Y; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Z5XOpG9m"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="lmuMvv1Y"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Z5XOpG9m"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="lmuMvv1Y" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 83C9477576; Mon, 13 Jul 2026 07:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783927094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P9bcDui1yDjtQ0aYNdF+7TWbkL6KIqyPbWR0Wpi7QOc=; b=Z5XOpG9myW12W1nJHWcCH+HfgBNuiirRTHUB2Le+QSx2swOwGQkrBZNv0Vc41gt8s6GN0Q qV8Sa9qRm3zocQGsgdW3Vsawlhe0eLVGdxL9rywqpuc4eOjkLHmvKUS+IeffiT2iJP1GuM 28zuVX/U+5vMifPpHqdsRXYmNQZPR5I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783927094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P9bcDui1yDjtQ0aYNdF+7TWbkL6KIqyPbWR0Wpi7QOc=; b=lmuMvv1Y9xp9dMqAe8ehlIIrTnc0y9glZ8jMphXcfOBC0hHti7BmSU9ihMT4ZwCMT3JBhD Ku1A2M9S+NmWXVBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Z5XOpG9m; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lmuMvv1Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783927094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P9bcDui1yDjtQ0aYNdF+7TWbkL6KIqyPbWR0Wpi7QOc=; b=Z5XOpG9myW12W1nJHWcCH+HfgBNuiirRTHUB2Le+QSx2swOwGQkrBZNv0Vc41gt8s6GN0Q qV8Sa9qRm3zocQGsgdW3Vsawlhe0eLVGdxL9rywqpuc4eOjkLHmvKUS+IeffiT2iJP1GuM 28zuVX/U+5vMifPpHqdsRXYmNQZPR5I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783927094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P9bcDui1yDjtQ0aYNdF+7TWbkL6KIqyPbWR0Wpi7QOc=; b=lmuMvv1Y9xp9dMqAe8ehlIIrTnc0y9glZ8jMphXcfOBC0hHti7BmSU9ihMT4ZwCMT3JBhD Ku1A2M9S+NmWXVBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 23E8B779AE; Mon, 13 Jul 2026 07:18:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XH7WBjaRVGoDXgAAD6G6ig (envelope-from ); Mon, 13 Jul 2026 07:18:14 +0000 Message-ID: <5b058b8e-bf2d-4911-a451-fe434881e033@suse.de> Date: Mon, 13 Jul 2026 09:18:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 11/16] nvme-rdma: Use CCR to recover controller that hits an error To: Mohamed Khalfella , Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Randy Jennings , Dhaval Giani Cc: Aaron Dailey , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260712022437.3743117-1-mkhalfella@purestorage.com> <20260712022437.3743117-12-mkhalfella@purestorage.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260712022437.3743117-12-mkhalfella@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[purestorage.com,broadcom.com,gmail.com,nvidia.com,lst.de,kernel.dk,kernel.org,grimberg.me]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_TWELVE(0.00)[15]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid,purestorage.com:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 83C9477576 X-Spam-Score: -4.51 On 7/12/26 4:23 AM, Mohamed Khalfella wrote: > An alive nvme controller that hits an error now will move to FENCING > state instead of RESETTING state. ctrl->fencing_work attempts CCR to > terminate inflight IOs. Regardless of the success or failure of CCR > operation the controller is transitioned to RESETTING state to continue > error recovery process. > > Signed-off-by: Mohamed Khalfella > --- > drivers/nvme/host/rdma.c | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > Same remarks as for the TCP version ... Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich