From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755367AbdKBINv (ORCPT ); Thu, 2 Nov 2017 04:13:51 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:48131 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755175AbdKBIMt (ORCPT ); Thu, 2 Nov 2017 04:12:49 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20171102081247euoutp0120b2117d1469d22b75b01f819d573a44~zNqF1k5nh0487304873euoutp01_ X-AuditID: cbfec7f2-f793b6d000003243-3e-59fad37ea57f Subject: Re: [PATCH 1/2] media: s5p-mfc: check for firmware allocation before requesting firmware To: Shuah Khan , kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, mchehab@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org From: Andrzej Hajda Message-id: <5bbc048a-4b68-de23-373d-eb8a12c5b736@samsung.com> Date: Thu, 02 Nov 2017 09:12:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset="utf-8" Content-transfer-encoding: 7bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGKsWRmVeSWpSXmKPExsWy7djP87p1l39FGuw6J2xxZO1VJouZJ9pZ Lc42vWG32PT4GqvF5V1z2Cx6NmxltVi26Q+TxdQvH1gcODw2repk89i8pN5jS/9ddo++LasY PT5vkvO4cqSRPYAtissmJTUnsyy1SN8ugSvj/5U+toJGnorz9y6xNTA+4exi5OCQEDCReDAh v4uRE8gUk7hwbz0biC0ksJRR4uTtlC5GLiD7M6PErh2dzBBFJhKf5y9ihUgsY5Q4vK0BquMZ o8TbK/wgtrBAskTvou9gRSICDYwSD1uPg3UzC6RKPHm7CKyBTUBT4u/mm2A2r4CdRMf/S+wg NouAqsTsEzvB6kUFIiSOH17OCFEjKPFj8j0WEJtTIEFix7HVbBAzNSVefJnEAmHLS2xe8xZq l7hEc+tNFpAjJAQes0kcm76GCeIFF4kppyGulhAQlnh1fAs7hC0j0dlxkAmioZtR4lP/CXYI ZwqjxL8PM6ABYC1x+PhFVogVfBKTtk1nhgQkr0RHmxCE6SFxcLEdRLWjxM3rR5ghwfWIUeJF /2/GCYzys5A8NAvJE7OQPDELyRMLGFlWMYqklhbnpqcWG+sVJ+YWl+al6yXn525iBKae0/+O f9rB+PWE1SFGAQ5GJR5eCa1fkUKsiWXFlbmHGCU4mJVEeF+dAArxpiRWVqUW5ccXleakFh9i lOZgURLntY1qixQSSE8sSc1OTS1ILYLJMnFwSjUw9u/bpBggHcOW99SUP70q2alW8VB+ssTP iSFaU+e6nr/vq35tkouu16nFn9VzQoKXyaWX5LcuO7xN6Xrkkkk3EgWF/987nFQv/7AwNU/b 4vhlhrS6vcJ+XVr/y9Kf6uV7zF2zuPji+viVdjsWMZxbv1OLdcKPh5dXW66XvvHRIi2MMdt4 78TVSizFGYmGWsxFxYkArDXYrzkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xq7q1l39FGsy8Y2RxZO1VJouZJ9pZ Lc42vWG32PT4GqvF5V1z2Cx6NmxltVi26Q+TxdQvH1gcODw2repk89i8pN5jS/9ddo++LasY PT5vkvO4cqSRPYAtissmJTUnsyy1SN8ugSvj/5U+toJGnorz9y6xNTA+4exi5OSQEDCR+Dx/ ESuELSZx4d56ti5GLg4hgSWMEp2r7zNDOM8YJR79uMcOUiUskCzx8OQjRpCEiEADo8SF5wvA EswCqRIzPj5mh+h4xCjxqvcEC0iCTUBT4u/mm2wgNq+AnUTH/0tgDSwCqhKzT+xkBrFFBSIk nje/Z4WoEZT4MfkeWC+nQIJEf/tLpi5GDqAF6hJTpuRC7JKX2LzmLTOELS7R3HqTZQKj4Cwk 3bMQOmYh6ZiFpGMBI8sqRpHU0uLc9NxiQ73ixNzi0rx0veT83E2MwDjZduzn5h2MlzYGH2IU 4GBU4uE9oP4rUog1say4MvcQowQHs5II76sTQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8vXtW RwoJpCeWpGanphakFsFkmTg4pRoYPexOPL6377ut3eOoe66vN02PM9ztb8o0Wcrs4btHjnu7 Ap7NMXZOXX2xu9L8WXzdidDz03Nc9VLLGIyaNb2i+UT6+kPfFVZUaB+/obsh+jZDtvC2LP2k yh0b5YMmfDgiP5ff0lS3J+3l7kNrCtrP3WqTX37lSMORqQwnTv9UWe8sP+Wf42FVJZbijERD Leai4kQAqCOuqo8CAAA= X-CMS-MailID: 20171102081245eucas1p201199ca2d214e59959ffe02f1579c8df X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171006213015epcas3p2c0d4741e06b2d8c25583fb656b7f5532 X-RootMTR: 20171006213015epcas3p2c0d4741e06b2d8c25583fb656b7f5532 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shuah, On 06.10.2017 23:30, Shuah Khan wrote: > Check if firmware is allocated before requesting firmware instead of > requesting firmware only to release it if firmware is not allocated. > > Signed-off-by: Shuah Khan > --- > drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c > index 69ef9c2..f064a0d1 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c > @@ -55,6 +55,11 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev) > * into kernel. */ > mfc_debug_enter(); > > + if (!dev->fw_buf.virt) { > + mfc_err("MFC firmware is not allocated\n"); > + return -EINVAL; > + } > + > for (i = MFC_FW_MAX_VERSIONS - 1; i >= 0; i--) { > if (!dev->variant->fw_name[i]) > continue; > @@ -75,11 +80,6 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev) > release_firmware(fw_blob); > return -ENOMEM; > } > - if (!dev->fw_buf.virt) { > - mfc_err("MFC firmware is not allocated\n"); > - release_firmware(fw_blob); > - return -EINVAL; > - } Is there any scenario in which dev->fw_buf.virt is null and s5p_mfc_load_firmware is called? I suspect this check is not necessary at all. Regards Andrzej > memcpy(dev->fw_buf.virt, fw_blob->data, fw_blob->size); > wmb(); > release_firmware(fw_blob);