From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755536AbcJFLEw (ORCPT ); Thu, 6 Oct 2016 07:04:52 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36300 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200AbcJFLEj (ORCPT ); Thu, 6 Oct 2016 07:04:39 -0400 Subject: Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings To: Mike Looijmans , devicetree@vger.kernel.org References: <1475676188-10639-1-git-send-email-mike.looijmans@topic.nl> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, robh+dt@kernel.org, mark.rutland@arm.com, andrew@lunn.ch From: Florian Fainelli Message-ID: <5c48a89f-3f2e-a74a-8e7b-a4b7397c2408@gmail.com> Date: Thu, 6 Oct 2016 04:04:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1475676188-10639-1-git-send-email-mike.looijmans@topic.nl> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2016 07:03 AM, Mike Looijmans wrote: > The KSZ9031 skew registers contain an offset, the chip's default value > is "neutral" which does not add any skew. Programming a 0 into a skew > property will actually set it the maximal negative adjustment and not > to a neutral position as one would expect. > > Explain this situation in the devicetree binding documentation and list > the settings that the chip considers neutral. > > Changing the implementation to accept negative values would have been > a better solution, but would break existing configurations. > > Signed-off-by: Mike Looijmans Reviewed-by: Florian Fainelli Thanks! -- Florian