From: Trilok Soni <soni.trilok@gmail.com>
To: Purushotam Kumar <purushotam@ti.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx
Subject: Re: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for DaVinci/DM6446.
Date: Mon, 16 Mar 2009 23:44:04 +0530 [thread overview]
Message-ID: <5d5443650903161114q4aa63bb9s405031c8a5bd0317@mail.gmail.com> (raw)
In-Reply-To: <1237214559-31345-1-git-send-email-purushotam@ti.com>
Hi Purshotam,
> +
> +
> +/* MMCSD Init clock in Hz in opendain mode */
s/opendain/opendrain
> +
> +static irqreturn_t mmc_davinci_irq(int irq, void *dev_id)
> +{
> + struct mmc_davinci_host *host = (struct mmc_davinci_host *)dev_id;
Unnecessary casting from void *.
> +
> + ret = -EBUSY;
> + mem_size = r->end - r->start + 1;
How about using resource_size(...) ?
> + mem = request_mem_region(r->start, mem_size, pdev->name);
> + if (!mem)
> + goto out;
> +
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("MMC/SD driver for Davinci MMC controller");
Adding MODULE_AUTHOR and MODULE_ALIAS would be great. You can also add
MAINTAINERS entry if you want.
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
next prev parent reply other threads:[~2009-03-16 18:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 14:42 Purushotam Kumar
2009-03-16 18:14 ` Trilok Soni [this message]
2009-03-17 10:14 ` Kumar, Purushotam
2009-03-16 18:40 ` David Brownell
2009-03-17 7:25 ` Kumar, Purushotam
2009-03-16 21:08 ` David Brownell
2009-03-17 7:30 ` Kumar, Purushotam
2009-03-22 15:12 ` Pierre Ossman
2009-03-26 8:58 ` Kumar, Purushotam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5443650903161114q4aa63bb9s405031c8a5bd0317@mail.gmail.com \
--to=soni.trilok@gmail.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=drzeus-mmc@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=purushotam@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®