From: DM <dm.n9107@gmail.com>
To: "Arjan van de Ven" <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, ak@suse.de,
mingo@elte.hu
Subject: Re: [patch 2/2] track and print last unloaded module in the oops trace
Date: Tue, 8 Jan 2008 15:39:45 +0100 [thread overview]
Message-ID: <5eeb9ad90801080639h2992e9b7maec0339e4f763f65@mail.gmail.com> (raw)
In-Reply-To: <20080108062656.311cd3aa@laptopd505.fenrus.org>
On Jan 8, 2008 3:26 PM, Arjan van de Ven <arjan@infradead.org> wrote:
> >
> > Why use sprintf? If a module name contains the % character we could
> > overflow the buffer. Or is module-unloading root-only and we don't
> > care?
>
> module loading isn't just root only; the name comes from an already loaded module.
> If you can load kernel modules of your choice you own the entire kernel already anway
>
Still, strcpy seems like a better choice IMHO.
/DM
next prev parent reply other threads:[~2008-01-08 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 23:19 Arjan van de Ven
2008-01-07 1:25 ` Rusty Russell
2008-01-08 11:23 ` Ingo Molnar
2008-01-08 11:52 ` Rusty Russell
2008-01-08 13:51 ` DM
2008-01-08 14:26 ` Arjan van de Ven
2008-01-08 14:39 ` DM [this message]
2008-01-08 16:18 ` Ingo Molnar
2008-01-08 21:20 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eeb9ad90801080639h2992e9b7maec0339e4f763f65@mail.gmail.com \
--to=dm.n9107@gmail.com \
--cc=ak@suse.de \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®