From: Finn Thain <fthain@linux-m68k.org>
To: Jens Axboe <axboe@kernel.dk>, Laurent Vivier <laurent@vivier.eu>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Joshua Thompson <funaho@jurai.org>,
linux-block@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 31/33] swim: Define macros for constants
Date: Fri, 04 Sep 2026 19:26:36 +1000 [thread overview]
Message-ID: <64ee742adc48218962a989017b9dc5622e2932c7.1788513997.git.fthain@linux-m68k.org> (raw)
In-Reply-To: <cover.1788513996.git.fthain@linux-m68k.org>
Define a SEL_MASK macro to name the anonymous constant. Define STEPPING
rather than re-use STEP because the latter is a command bit macro (see also
GCR_MODE vs. SETGCR). No functional change, just better readability.
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Finn Thain <fthain@linux-m68k.org>
---
drivers/block/swim.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/block/swim.c b/drivers/block/swim.c
index a5be31b732b5..6f37a01219c2 100644
--- a/drivers/block/swim.c
+++ b/drivers/block/swim.c
@@ -105,6 +105,8 @@ struct iwm {
/* Select values for swim_select and swim_readbit */
+#define SEL_MASK 0x100
+
#define SEEK_POSITIVE 0x000
#define SEEK_NEGATIVE 0x004
#define STEP 0x001
@@ -115,6 +117,7 @@ struct iwm {
#define SETMFM 0x101
#define SETGCR 0x105
+#define STEPPING 0x001
#define READ_DATA_0 0x004
#define ONEMEG_DRIVE 0x005
#define SINGLE_SIDED 0x006
@@ -271,7 +274,7 @@ static inline void swim_select(struct swim __iomem *base, int sel)
{
swim_write(base, phase, RELAX | PHASE_PIN_DIR);
- via1_set_head(sel & 0x100);
+ via1_set_head(sel & SEL_MASK);
swim_write(base, phase, (sel & CA_MASK) | PHASE_PIN_DIR);
}
@@ -366,7 +369,7 @@ static int swim_step(struct swim __iomem *base)
{
swim_action(base, STEP);
udelay(150);
- return swim_readbit_timeout(base, STEP, false, 20 * 1000);
+ return swim_readbit_timeout(base, STEPPING, false, 20 * 1000);
}
static int swim_track00(struct swim __iomem *base)
--
2.52.0
next prev parent reply other threads:[~2026-09-04 9:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 9:26 [PATCH v3 00/33] block/swim: Fixes and improvements Finn Thain
2026-09-04 9:26 ` [PATCH v3 25/33] swim: Don't search beyond the first data mark Finn Thain
2026-09-04 9:26 ` [PATCH v3 21/33] swim: Check drive ready bit Finn Thain
2026-09-04 9:26 ` [PATCH v3 12/33] swim: Handle FIFO timeout error Finn Thain
2026-09-04 9:26 ` [PATCH v3 01/33] swim: Assert strobe with stable outputs Finn Thain
2026-09-04 9:26 ` [PATCH v3 16/33] swim: Don't use the mark register to read data Finn Thain
2026-09-04 9:26 ` [PATCH v3 05/33] swim: Perform ISM/IWM mode switching according to specs Finn Thain
2026-09-04 9:26 ` [PATCH v3 07/33] swim: Refactor SWIM setup Finn Thain
2026-09-04 9:26 ` [PATCH v3 15/33] swim: Check error register during sector read Finn Thain
2026-09-04 9:26 ` [PATCH v3 23/33] swim: Remove pointless mode0 register write Finn Thain
2026-09-04 9:26 ` [PATCH v3 10/33] swim: Recalibrate when drive is probed Finn Thain
2026-09-04 9:26 ` [PATCH v3 22/33] swim: Revisit delays Finn Thain
2026-09-04 9:26 ` [PATCH v3 30/33] swim: Clean up whitespace Finn Thain
2026-09-04 9:26 ` [PATCH v3 02/33] swim: Select appropriate drive once only Finn Thain
2026-09-04 9:26 ` [PATCH v3 29/33] swim: Remove unused macro definitions Finn Thain
2026-09-04 9:26 ` [PATCH v3 08/33] swim: Enable clock divider only where appropriate Finn Thain
2026-09-04 9:26 ` [PATCH v3 06/33] swim: Configure parameter memory Finn Thain
2026-09-04 9:26 ` [PATCH v3 27/33] swim: Move swd initialization Finn Thain
2026-09-04 9:26 ` [PATCH v3 14/33] swim: Check for CRC errors Finn Thain
2026-09-04 9:26 ` [PATCH v3 11/33] swim: Add track zero recalibration delay Finn Thain
2026-09-04 9:26 ` [PATCH v3 24/33] swim: Don't needlessly re-read sectors Finn Thain
2026-09-04 9:26 ` [PATCH v3 26/33] swim: Remove pointless specifiers Finn Thain
2026-09-04 9:26 ` [PATCH v3 13/33] swim: Simplify return value initialization Finn Thain
2026-09-04 9:26 ` [PATCH v3 04/33] swim: Don't disable drive after every sector Finn Thain
2026-09-04 9:26 ` [PATCH v3 18/33] swim: Convert to blocking queue Finn Thain
2026-09-04 9:26 ` [PATCH v3 03/33] swim: Enable the drive when probing Finn Thain
2026-09-04 9:26 ` [PATCH v3 28/33] swim: Add some helpful references Finn Thain
2026-09-04 9:26 ` [PATCH v3 09/33] swim: Don't start motor until medium is present Finn Thain
2026-09-04 9:26 ` [PATCH v3 33/33] swim: Unexport global symbols Finn Thain
2026-09-04 9:26 ` [PATCH v3 32/33] swim: Define symbols for constants Finn Thain
2026-09-04 9:26 ` Finn Thain [this message]
2026-09-04 9:26 ` [PATCH v3 17/33] swim: Fix buffer overflow Finn Thain
2026-09-04 9:26 ` [PATCH v3 19/33] swim: Remove redundant RELAX actions Finn Thain
2026-09-04 9:26 ` [PATCH v3 20/33] swim: Deduplicate polling loops Finn Thain
2026-09-23 8:26 ` [PATCH v3 00/33] block/swim: Fixes and improvements Stanley J. Johnson
2026-09-23 11:15 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64ee742adc48218962a989017b9dc5622e2932c7.1788513997.git.fthain@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=axboe@kernel.dk \
--cc=funaho@jurai.org \
--cc=geert@linux-m68k.org \
--cc=laurent@vivier.eu \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®