From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752948AbdHQN7Q (ORCPT ); Thu, 17 Aug 2017 09:59:16 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:37039 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752586AbdHQN7O (ORCPT ); Thu, 17 Aug 2017 09:59:14 -0400 From: Amelie DELAUNAY To: Sergei Shtylyov , Greg Kroah-Hartman , Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre TORGUE , "John Youn" CC: "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Benjamin GAIGNARD Subject: Re: [PATCH 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU Thread-Topic: [PATCH 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU Thread-Index: AQHTFzxi1dQWI9GcJ0CpgbWSMEhei6KIPF0AgAA1dwA= Date: Thu, 17 Aug 2017 13:58:34 +0000 Message-ID: <6623149d-fe9d-a173-52d5-ee558d55ece4@st.com> References: <1502962386-6683-1-git-send-email-amelie.delaunay@st.com> <1502962386-6683-7-git-send-email-amelie.delaunay@st.com> <804e0eb3-88a0-2847-9330-0f92d36f9f99@cogentembedded.com> In-Reply-To: <804e0eb3-88a0-2847-9330-0f92d36f9f99@cogentembedded.com> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-Type: text/plain; charset="utf-8" Content-ID: <0BFD8DFFF673B54D9778ED92B8478BDF@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-17_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7HDxKQC011288 On 08/17/2017 12:47 PM, Sergei Shtylyov wrote: > On 8/17/2017 12:33 PM, Amelie Delaunay wrote: > >> This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC. >> >> Signed-off-by: Amelie Delaunay >> --- >> arch/arm/boot/dts/stm32f746.dtsi | 31 +++++++++++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> >> diff --git a/arch/arm/boot/dts/stm32f746.dtsi >> b/arch/arm/boot/dts/stm32f746.dtsi >> index fcfe5a6..a9476ea 100644 >> --- a/arch/arm/boot/dts/stm32f746.dtsi >> +++ b/arch/arm/boot/dts/stm32f746.dtsi >> @@ -419,6 +419,28 @@ >> slew-rate = <2>; >> }; >> }; >> + >> + usbotg_fs_pins_a: usbotg_fs@0 { > > Dashes are preferred to underlines in the node names. You're right. I'll fix it in v2. Thanks. > > [...] > > MBR, Sergei Regards, Amelie