From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756521AbcKKMs5 (ORCPT ); Fri, 11 Nov 2016 07:48:57 -0500 Received: from mga06.intel.com ([134.134.136.31]:62824 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754978AbcKKMs4 (ORCPT ); Fri, 11 Nov 2016 07:48:56 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,621,1473145200"; d="scan'208";a="1083890569" Subject: Re: [PATCH] mmc: sdhci: remove unneeded (void *) casts in sdhci_(pltfm_)priv() To: Masahiro Yamada , linux-mmc@vger.kernel.org References: <1478784138-18594-1-git-send-email-yamada.masahiro@socionext.com> Cc: linux-kernel@vger.kernel.org, Ulf Hansson From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <664579d5-a5be-bcc8-a24e-d725c8552b4a@intel.com> Date: Fri, 11 Nov 2016 14:43:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1478784138-18594-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/16 15:22, Masahiro Yamada wrote: > The type of host->private is (unsigned long *). No cast is needed > to return an opaque pointer. > > Signed-off-by: Masahiro Yamada Acked-by: Adrian Hunter > --- > > drivers/mmc/host/sdhci-pltfm.h | 2 +- > drivers/mmc/host/sdhci.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h > index 3280f20..957839d 100644 > --- a/drivers/mmc/host/sdhci-pltfm.h > +++ b/drivers/mmc/host/sdhci-pltfm.h > @@ -106,7 +106,7 @@ extern int sdhci_pltfm_register(struct platform_device *pdev, > > static inline void *sdhci_pltfm_priv(struct sdhci_pltfm_host *host) > { > - return (void *)host->private; > + return host->private; > } > > extern const struct dev_pm_ops sdhci_pltfm_pmops; > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index 766df17..9886115 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -655,7 +655,7 @@ extern struct sdhci_host *sdhci_alloc_host(struct device *dev, > > static inline void *sdhci_priv(struct sdhci_host *host) > { > - return (void *)host->private; > + return host->private; > } > > extern void sdhci_card_detect(struct sdhci_host *host); >