From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Brian Gerst <brgerst@gmail.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>, Stas Sergeev <stsp@list.ru>,
Andy Lutomirski <luto@kernel.org>
Subject: [RFC 1/4] x86/signal/64: Add a comment about sigcontext->fs and gs
Date: Mon, 12 Oct 2015 18:04:05 -0700 [thread overview]
Message-ID: <66cb936904b7ce56ddc1ce58119bd9683e4f3b43.1444697927.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1444697927.git.luto@kernel.org>
In-Reply-To: <cover.1444697927.git.luto@kernel.org>
These fields have a strange history. This tries to document it.
This borrows from 9a036b93a344 ("x86/signal/64: Remove 'fs' and 'gs'
from sigcontext"), which was reverted by ed596cde9425 ("Revert x86
sigcontext cleanups").
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
arch/x86/include/uapi/asm/sigcontext.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/x86/include/uapi/asm/sigcontext.h b/arch/x86/include/uapi/asm/sigcontext.h
index 40836a9a7250..827c6ed0e26a 100644
--- a/arch/x86/include/uapi/asm/sigcontext.h
+++ b/arch/x86/include/uapi/asm/sigcontext.h
@@ -177,6 +177,24 @@ struct sigcontext {
__u64 rip;
__u64 eflags; /* RFLAGS */
__u16 cs;
+
+ /*
+ * Prior to 2.5.64 ("[PATCH] x86-64 updates for 2.5.64-bk3"),
+ * Linux saved and restored fs and gs in these slots. This
+ * was counterproductive, as fsbase and gsbase were never
+ * saved, so arch_prctl was presumably unreliable.
+ *
+ * If these slots are ever needed for any other purpose, there
+ * is some risk that very old 64-bit binaries could get
+ * confused. I doubt that many such binaries still work,
+ * though, since the same patch in 2.5.64 also removed the
+ * 64-bit set_thread_area syscall, so it appears that there is
+ * no TLS API that works in both pre- and post-2.5.64 kernels.
+ *
+ * There is at least one additional concern if these slots are
+ * recycled for another purpose: some DOSEMU versions stash fs
+ * and gs in these slots manually.
+ */
__u16 gs;
__u16 fs;
__u16 __pad0;
--
2.4.3
next prev parent reply other threads:[~2015-10-13 1:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 1:04 [RFC 0/4] x86: sigcontext SS fixes, take 2 Andy Lutomirski
2015-10-13 1:04 ` Andy Lutomirski [this message]
2015-10-13 1:04 ` [RFC 2/4] x86/signal/64: Fix SS if needed when delivering a 64-bit signal Andy Lutomirski
2015-10-13 1:04 ` [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit signal context Andy Lutomirski
2015-10-13 14:59 ` Stas Sergeev
2015-10-14 15:01 ` Ingo Molnar
2015-10-14 15:09 ` Stas Sergeev
2015-10-14 16:40 ` Andy Lutomirski
2015-10-14 17:40 ` Stas Sergeev
2015-10-14 18:06 ` Andy Lutomirski
2015-10-14 18:34 ` Stas Sergeev
2015-10-14 18:52 ` Andy Lutomirski
2015-10-14 21:37 ` Stas Sergeev
2015-10-14 21:41 ` Andy Lutomirski
2015-10-18 13:36 ` Stas Sergeev
2015-10-18 16:12 ` Andy Lutomirski
2015-10-18 16:29 ` Stas Sergeev
2015-10-18 16:36 ` Andy Lutomirski
2015-10-18 16:43 ` Stas Sergeev
2015-10-18 17:06 ` Andy Lutomirski
2015-10-14 16:40 ` Cyrill Gorcunov
2015-10-14 16:42 ` Andy Lutomirski
2015-10-14 16:57 ` Cyrill Gorcunov
2015-10-14 16:57 ` Stas Sergeev
2015-10-14 17:01 ` Cyrill Gorcunov
2015-10-13 1:04 ` [RFC 4/4] selftests/x86: Add tests for UC_SIGCONTEXT_SS and UC_STRICT_RESTORE_SS Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66cb936904b7ce56ddc1ce58119bd9683e4f3b43.1444697927.git.luto@kernel.org \
--to=luto@kernel.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stsp@list.ru \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®