From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29BE6369236 for ; Tue, 19 May 2026 19:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779220437; cv=none; b=c0VMi9Xs2bg7ryHIZdQx9g4CyrPpDZVkRf5bw61b30gRjjeMY7iO2mHef5cHOgIrnHYxTaykXzcQyNE2sBeBQ9YszesZ8DjpZ2n/YgVxqdOutyLnLMV7Ie0hoyC87dxM6tLYBQbpcrWzTM5I01rcuH9/CrFMTc8P65CUO4fbUso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779220437; c=relaxed/simple; bh=/yTXDUcSInNPHQIymKXgDkqeJ6bUbDCeIiKyGSieagQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=llBYDvds6yFfZ/d4juzf+iZfTwnc9j/5ZhnlVNxRzEoJ1y8gt3gLlBUbIAr4H+bBbXA2HLYbeau5zdhKD6Htpwy9Uy/61d1bp92MC+dwkvokuBs7sDkQWJUuYjyowdOjA/2alkEhisIkCbwxAF2GKNmuZjhBmCOF8hyit9s8/+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CUK2cafY; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CUK2cafY" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2f36da5c8fbso3630216eec.0 for ; Tue, 19 May 2026 12:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779220435; x=1779825235; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LBJpoz9+FDWyOZgmi5e6eowXrSWpVTMQLtjKWJI9K/w=; b=CUK2cafYarBHtR233nBcJ46qJEPUFZpr+AOUBxHFGSxbnGsdnWl0+yPx0xs+V3KPk+ uZPg/UfIglkF2sHEMMltqQ7Oa4JlyWMTWmc9aSejgYSdkJ/5fv4EZJNXvhr6VuJfwKC6 OwrPj3t9kWpDUuP+ZmDmcyILzK9HBkpAovEn2c6KxYc70uQLnLnInDGxRlJTOybm6OQT nj4i4MC8Da0j2PxS8VPVWmcqvGzMgATm3g+I+zNXWPBLleufCsHnbp0BmZi+9u7aE0jI ijNf/c4qp0/8LYmpzxKGNC7JOPasZoqBxxgdFZyfKXytuulTQ+N/CTWdjYGuvJXqwJ9S ifVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779220435; x=1779825235; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LBJpoz9+FDWyOZgmi5e6eowXrSWpVTMQLtjKWJI9K/w=; b=pgSfzHsuaS/IYKuY/NNEV6DWqS2eAo4kgaAyQOQMOVmBrSu6nMbH1kFovMPLWABkOa L3aMuQ1jJNg1NbvGtTmDFjmzUr6PcbNTMRJ/15W32QAB/jrm0tNf9GixlwhZTBloSMfA KGPFHcuMzdE0iEJKYQOBimozEOLAx7zBW6lc/+q4RBiEaUi9RnzHmErVSNvXWxVBExb0 Ipc0MfeXH6FH6gaHuc86Xbb6kkEc0x0nmyCOtrMtbsS5NP25spuhTpXDRfoXrnESTW1d Hn5uVe3g39m1YNMHpVRTrqcRrUP26ln3OoWs8IaMovf2cWNcRdIYxQ/Fp63sW2rWk40o dtcQ== X-Forwarded-Encrypted: i=1; AFNElJ8OqZispxG3nH41NKJsLd7dn3YGwSDL52D9jerXW/9HiDUayeFOVzrZW2AoIOL83kQTimQuuHp3g1S5AQI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4eeUMPkNIcguP75BlQUtzfA+V5hKCkfDv0doqzDknXaNevjHf WP42cyefLNMV65Lekg+Oa46PMLFdbgGsPBDkABMQVElOIPVYSi4aTeqA X-Gm-Gg: Acq92OGcyeKlevag5cxD1tTo6MCDW9nJ9cZ/JjVnwZB6BvvwiaHbkC3E8EFUNGA3Xx0 PxKt9ihzZrObQO8Jp0VuMyCHkX8QnjJQdLcpT9DFJtgbCoLMUpuvXUlVk6lvpi2zpje4oHkI+0H 2IlZToPe5sp2BXYNPZYz7FoVtt8rzsuYxV8mbvFOxDUHrHhZI/T56vveTy8HE7bimVfys7MqZbM e6CAqHp+mpkGGIKDWW3XT32MIZaAzZdfQ7f+LBMZp0jUd9hzhgs1+u11VAYzIssqngpn4YI7CZl JJ1je2yteuvexLTN1NJpbFjLxM4yulw/YDj9fxTK12xD3euvNB48H6ebS3JIchpKys5k6H+2GaH nrXZB97oLWVqFjq4nLDZkFSV9vXpRqzqxOcR3I7LXQzSRddPkyInyJUIO1UGAGrxjaUNY+mTgFK vn48CU7CVuFwQ106phYrOJBqt6QuINlmzYbuGF5tHquvRDj9OPp7bTiiBKPOmFOpo1VxwNVg2PW pq3QBPiiwkGzzY= X-Received: by 2002:a05:7300:a94b:b0:2ed:a64:a457 with SMTP id 5a478bee46e88-303986552f6mr9519696eec.20.1779220435225; Tue, 19 May 2026 12:53:55 -0700 (PDT) Received: from [10.69.76.71] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30296dcb6e9sm20827669eec.16.2026.05.19.12.53.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 12:53:54 -0700 (PDT) Message-ID: <67ad1039-b6e7-4507-a9be-12600a5fe385@gmail.com> Date: Tue, 19 May 2026 12:52:36 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] scsi: lpfc: fix potential memory leak in lpfc_read_object() To: Abdun Nihaal Cc: justin.tee@broadcom.com, paul.ely@broadcom.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jsmart2021@gmail.com, stable@vger.kernel.org References: <20260519074230.110624-1-nihaal@cse.iitm.ac.in> Content-Language: en-US From: Justin Tee In-Reply-To: <20260519074230.110624-1-nihaal@cse.iitm.ac.in> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Abdun, > The memory allocated for sge_array inside lpfc_sli4_config() which is > attached to mbox, is not freed in one of the error path in > lpfc_read_object(). Fix that by calling lpfc_sli4_mbox_cmd_free() > instead of directly freeing the mbox. I don’t believe this is true because in lpfc_read_object(), lpfc_sli4_config() is called with LPFC_SLI4_MBX_EMBED.  So, sge_array is not kzalloc’ed.  The code as it is today seems already correct without this patch. Regards, Justin