From: Geliang Tang <geliangtang@gmail.com>
To: "Felipe Balbi" <balbi@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Michal Nazarewicz" <mina86@mina86.com>,
"Vincent Pelletier" <plr.vincent@gmail.com>,
"Felix Hädicke" <felixhaedicke@web.de>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Jim Lin" <jilin@nvidia.com>
Cc: Geliang Tang <geliangtang@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: gadget: f_fs: use memdup_user
Date: Sat, 13 May 2017 11:15:59 +0800 [thread overview]
Message-ID: <694b8a4beb2ec1e087321bc423e5cd0c69e5a717.1494576863.git.geliangtang@gmail.com> (raw)
In-Reply-To: <908fa521decaf3703e172c3734c0d498741f3ddb.1494580404.git.geliangtang@gmail.com>
Use memdup_user() helper instead of open-coding to simplify the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
drivers/usb/gadget/function/f_fs.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
index 71dd27c..5754538 100644
--- a/drivers/usb/gadget/function/f_fs.c
+++ b/drivers/usb/gadget/function/f_fs.c
@@ -3692,14 +3692,9 @@ static char *ffs_prepare_buffer(const char __user *buf, size_t len)
if (unlikely(!len))
return NULL;
- data = kmalloc(len, GFP_KERNEL);
- if (unlikely(!data))
- return ERR_PTR(-ENOMEM);
-
- if (unlikely(copy_from_user(data, buf, len))) {
- kfree(data);
- return ERR_PTR(-EFAULT);
- }
+ data = memdup_user(buf, len);
+ if (unlikely(IS_ERR(data)))
+ return data;
pr_vdebug("Buffer from user space:\n");
ffs_dump_mem("", data, len);
--
2.9.3
next prev parent reply other threads:[~2017-05-13 3:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 3:15 [PATCH] KEYS: " Geliang Tang
2017-05-13 3:15 ` [PATCH] mmc: block: " Geliang Tang
2017-05-19 7:43 ` Ulf Hansson
2017-05-13 3:15 ` Geliang Tang [this message]
2017-05-13 8:05 ` [PATCH] usb: gadget: f_fs: " Dan Carpenter
2017-05-21 3:25 ` Al Viro
2017-05-14 11:33 ` Michal Nazarewicz
2017-05-13 3:16 ` [PATCH] USB: iowarrior: " Geliang Tang
2017-05-15 10:14 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=694b8a4beb2ec1e087321bc423e5cd0c69e5a717.1494576863.git.geliangtang@gmail.com \
--to=geliangtang@gmail.com \
--cc=balbi@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=felixhaedicke@web.de \
--cc=gregkh@linuxfoundation.org \
--cc=jilin@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=plr.vincent@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®