From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60F363F1651 for ; Fri, 29 May 2026 15:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780068246; cv=none; b=W81/7VntUPq/d/7rQ9lldFxVca9/KzsgmNlanKDIx/6Go2defbUB6VgpRgUvSC68rhu55L698AmgBDtRHsPbzcnHrKZluVuylR1swCXeosFxNmXsdkwNHHw6jFJjPE41NZun27t33nwOhBMq8n5AwGYZLDK6/IeqOI011sb3rh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780068246; c=relaxed/simple; bh=xLQXzmmGjvEYiJuwU2B0ROV9KzzjJEnYf6CxLCTRo/c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a8Dw9dFslQ6mJt9EH+AN8ldGPNk8YO5mnb9oIJw33UDq8Gcd40tnbPXCXl7wITgP4OUg5goRhx6BDFy1bZ4VadEwbKGMZzaXbtNAX/VSjVHe+WsuemGCU4IhkYL5qLRYK7Y/AcUVm9/6GS8vaMNP3ibxm6kMt33PtNhp+m5bECk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ivKOvE5I; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=GuSCZK4z; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ivKOvE5I"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="GuSCZK4z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780068244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p8FgYlTim+1qafXpBvmXgDRFgmjZT3BzBxl1fqmzl20=; b=ivKOvE5IumAu6zBp2sy/LwrAw4gvCQ7dDc1mIPzV8A8GFzGlclvZYXm+OarE5s6plf+nLG a0ShWOYD0vdIdBis7kbLm51PUUXnfbYeZeXS6PCaOTpq7jejX7egLrEiuRuub4EYYK89Io dXmrjSjWCkIlaXYbbDHyPSCBymBMzzs= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-I2qHAMZkOAmkDFy_Vyhzig-1; Fri, 29 May 2026 11:24:03 -0400 X-MC-Unique: I2qHAMZkOAmkDFy_Vyhzig-1 X-Mimecast-MFC-AGG-ID: I2qHAMZkOAmkDFy_Vyhzig_1780068242 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-45ef63d1214so173135f8f.3 for ; Fri, 29 May 2026 08:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780068242; x=1780673042; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=p8FgYlTim+1qafXpBvmXgDRFgmjZT3BzBxl1fqmzl20=; b=GuSCZK4zaO6C+iaWzVWCNPJYjKVRx0/6Cc/jHlJ9faJPbRUGGLLUuPNewX7MnLeDjD xO4keU3sWVJZpTFVXarTZ1fB/hsqtDFkW5E5To5Wq6Ykp2b17nWIkHhEKXGetk3hl75S bsWZT4qZAEdJd5VG9ICstiFGQe0d0a+JoNm/WMqDR2K9keCWnIX/TC97ag3rj4J7sghN QnUOqZF4Ng8eoY9TljY6wN/g5FH75At6JUnYq/hHt4NQpHpA3fzPl4z3C5yNzdzYtdgl r1nIeKRlAr9QQJw35YAKY3VNfD6LCFQan3R3xVzQaGh4Tn5U+EVdqltPQhP0+z9dWwrh kixQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780068242; x=1780673042; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p8FgYlTim+1qafXpBvmXgDRFgmjZT3BzBxl1fqmzl20=; b=G7lJqU/KBeNAVAe0dEtavd4W2kZ3NxoLiXgaH2Xn4klwckrP5R5nWJ9lJREwK2fXyp uLsZTZAWfx8+5awoQDQcVI+1BtxHIeMOI4xya0csZiJArt8+HWNslERhWHLUQHo5gEw8 2XnhHhgA3YBtEZ6oRNJvgu7GKNbjmZN8ZsLTr/H1eOiywfanr0op3Y05WrnOO7eZakoz OU6IsTvpLiit99H0y9/5DqR/vCXbVnrXUjy4lQLljXtdjRSUclghN1zOACjDPxRSjCfl ZFMDAESa4BUn3+NdizDB5U5Hapnzhvc3LNLWXfuSviJnAprUd08oU2JBr60s/KIyGP9f 8zDA== X-Gm-Message-State: AOJu0YwF1Otp2xJH/S/F5SEyXAtSPHlq8QqLV7tP8eOLFE8lxiDATTBX pYvW0jaxvQrb7w92C0jLxinSvzTYuLB+ju9SlI4N6xN0G/F8YI+cskXtsIxtrpH3pZzKHEpCtJR dJbzfdLLauiBEosmMenAXV8espCNbLcwDyhY+hTJbsKr/PkyOMHDJPITZ2n+gn+OyoZrAYS1bPr zymCbkQXZBJzxiQBMU1QaPW5l3+mEznrFTJkhYJkUMP0k= X-Gm-Gg: Acq92OHZYZJ46vEc2AacqwY7cyTekjB6gceOza4bPkCpoynXYRhWGDGW1+qQAI5WPaW 9WwZKPpweYDsopT6SVr72+9d7+bMVCjBPT3Atmor8h/4ohX6bkprN6ZuU6FUdts54qLM9IWcafR aLCWwRC9wI4K3B7iqmQlmiCHymsN7f/r08JsQEqtjYoeb9UbJit8BPq0f5xpjSwmrrESX+hWxLM RwyrroSbPIl6PRFy2OGhGYbUZwo9yYxJeJjbVQvCQTWBh90AQ34k0k+nLBVQevpzUTPfxcNeQJo mbmGEKAyRRS3IOvNOEmETRh/3DOEwQIBLKkVuql9G1sgbLaPKQzv/VZd1IRbgA1jqnYRQOpC8+K AkwcWNdIkT72OKXAdU1emQPZ59ztE49GnKHb9SRbDS90b8HuxN5lGmA== X-Received: by 2002:a05:600d:6445:20b0:490:4f91:5519 with SMTP id 5b1f17b1804b1-490a2958db9mr849535e9.18.1780068241850; Fri, 29 May 2026 08:24:01 -0700 (PDT) X-Received: by 2002:a05:600d:6445:20b0:490:4f91:5519 with SMTP id 5b1f17b1804b1-490a2958db9mr848535e9.18.1780068241185; Fri, 29 May 2026 08:24:01 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-45.inter.net.il. [80.230.25.45]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c104920sm16482535e9.21.2026.05.29.08.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 08:24:00 -0700 (PDT) Date: Fri, 29 May 2026 11:23:56 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v9 19/37] mm: use __GFP_ZERO in vma_alloc_anon_folio_pmd Message-ID: <6dcf0045e069812ef06a71ebcf67ef0c819eb51d.1780067977.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Convert vma_alloc_anon_folio_pmd() to pass __GFP_ZERO instead of zeroing at the callsite. post_alloc_hook uses the fault address passed through vma_alloc_folio for cache-friendly zeroing. Note: with __GFP_ZERO, the folio is zeroed before mem_cgroup_charge(). If the charge fails, the zeroing work is wasted. Previously zeroing was done after a successful charge. This is inherent to moving zeroing into the allocator. Signed-off-by: Michael S. Tsirkin Reviewed-by: Gregory Price Assisted-by: Claude:claude-opus-4-6 --- mm/huge_memory.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index d689e6491ddb..4978d34532ea 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1333,7 +1333,7 @@ EXPORT_SYMBOL_GPL(thp_get_unmapped_area); static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, unsigned long addr) { - gfp_t gfp = vma_thp_gfp_mask(vma); + gfp_t gfp = vma_thp_gfp_mask(vma) | __GFP_ZERO; const int order = HPAGE_PMD_ORDER; struct folio *folio; @@ -1356,17 +1356,9 @@ static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, } folio_throttle_swaprate(folio, gfp); - /* - * When a folio is not zeroed during allocation (__GFP_ZERO not used) - * or user folios require special handling, folio_zero_user() is used to - * make sure that the page corresponding to the faulting address will be - * hot in the cache after zeroing. - */ - if (user_alloc_needs_zeroing()) - folio_zero_user(folio, addr); /* * The memory barrier inside __folio_mark_uptodate makes sure that - * folio_zero_user writes become visible before the set_pmd_at() + * page zeroing becomes visible before the set_pmd_at() * write. */ __folio_mark_uptodate(folio); -- MST