From: David Sterba <dsterba@suse.com>
To: torvalds@linux-foundation.org
Cc: Hyungjung Joo <jhj140711@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
David Sterba <dsterba@suse.com>
Subject: [PATCH 1/1] affs: bound hash_pos before table lookup in affs_readdir
Date: Fri, 10 Apr 2026 03:38:26 +0200 [thread overview]
Message-ID: <6fa253b38b9b293a0de2a361de400557ca7666ca.1775783818.git.dsterba@suse.com> (raw)
In-Reply-To: <cover.1775783818.git.dsterba@suse.com>
From: Hyungjung Joo <jhj140711@gmail.com>
affs_readdir() decodes ctx->pos into hash_pos and chain_pos and then
dereferences AFFS_HEAD(dir_bh)->table[hash_pos] before validating
that hash_pos is within the runtime table bound. Treat out-of-range
positions as end-of-directory before the first table lookup.
Signed-off-by: Hyungjung Joo <jhj140711@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---
fs/affs/dir.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/affs/dir.c b/fs/affs/dir.c
index 5c8d83387a39..075c18c4ccde 100644
--- a/fs/affs/dir.c
+++ b/fs/affs/dir.c
@@ -119,6 +119,8 @@ affs_readdir(struct file *file, struct dir_context *ctx)
pr_debug("readdir() left off=%d\n", ino);
goto inside;
}
+ if (hash_pos >= AFFS_SB(sb)->s_hashsize)
+ goto done;
ino = be32_to_cpu(AFFS_HEAD(dir_bh)->table[hash_pos]);
for (i = 0; ino && i < chain_pos; i++) {
--
2.51.0
next prev parent reply other threads:[~2026-04-10 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 1:38 [GIT PULL] AFFS fix for 7.1 David Sterba
2026-04-10 1:38 ` David Sterba [this message]
2026-04-14 0:29 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fa253b38b9b293a0de2a361de400557ca7666ca.1775783818.git.dsterba@suse.com \
--to=dsterba@suse.com \
--cc=jhj140711@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®