From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754047AbcKUKfW (ORCPT ); Mon, 21 Nov 2016 05:35:22 -0500 Received: from www381.your-server.de ([78.46.137.84]:34113 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753925AbcKUKfS (ORCPT ); Mon, 21 Nov 2016 05:35:18 -0500 Subject: Re: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage To: Sylwester Nawrocki , Krzysztof Kozlowski References: <1479669895-19124-1-git-send-email-krzk@kernel.org> <1479669895-19124-3-git-send-email-krzk@kernel.org> <8b81b058-0ba9-f1bc-a0ed-d30604853110@samsung.com> Cc: Sangbeom Kim , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org From: Lars-Peter Clausen Message-ID: <713e7f53-16b2-a510-e99e-77e785f8a7c1@metafoo.de> Date: Mon, 21 Nov 2016 11:34:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <8b81b058-0ba9-f1bc-a0ed-d30604853110@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Authenticated-Sender: lars@metafoo.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/2016 11:30 AM, Sylwester Nawrocki wrote: > On 11/20/2016 08:24 PM, Krzysztof Kozlowski wrote: >> MACH_SMDKC100, MACH_SMDKV210 and MACH_SMDKC110 are no longer supported >> so we can drop the dead code. After this the driver no longer >> differentiates between machines (S3C24xx machines are not supported by >> it) so there is no need to override I2S device id in cpu_dai_name and >> SEC_PLAYBACK dai_link can be removed as well. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> >> Not tested. The driver did not override .platform_name which looks >> suspicious to me. However I did not want to add changes which could have >> some visible impact on output code. > > The patch looks good to me. However the existing smdk64xx sound support > less so. I don't have smdk6410 set up for testing yet, possibly I get > around that next week. > Indeed it's strange .platform_name is not also "samsung-i2s.2". I think that is a fallout from commit a08485d8fdf6f ("ASoC: Samsung: Do not register samsung audio dma device as pdev"). Given nobody noticed this in the last 4 years maybe its time to drop this machine driver as well.