Re: [PATCH] sata_sil: combined irq + LBT DMA patch for testing

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: Richard Bollinger <rabollinger@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	Thomas Backlund <tmb@mandriva.org>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sata_sil: combined irq + LBT DMA patch for testing
Date: Fri, 27 Jan 2006 11:29:37 -0500	[thread overview]
Message-ID: <7744a2840601270829o135bb1c9ld0283042a0849abd@mail.gmail.com> (raw)
In-Reply-To: <58cb370e0601250826m330984g576839345ed908de@mail.gmail.com>

On 1/25/06, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> Hi,
> ...
> I think I have finally found the bug
> after auditing the patch for x times...
>
> +       /* Stop DMA, if doing DMA */
> +       switch (qc->tf.protocol) {
> +       case ATA_PROT_DMA:
> +       case ATA_PROT_ATAPI_DMA:
> +               ata_bmdma_stop(qc);
>
> It should be sil_bmdma_stop()...
>
> By accident ata_bmdma_stop() is OK for sil3112 so that would
> explain why only people with sil3114 reported problems.
>
> My theory is that using ata_bmdma_stop() for sil3114 results
> in IRQs for port 2 and 3 not being delivered (because
> SIL_INTR_STEERING bit is cleared) and we end up with
> dma_stat_mask == 0.
>
> Rest of the patch looks perfectly fine for me.  Could somebody
> reporting problems with this patch retest with the above change?
> ...
> Bartlomiej
>
Still no joy... after a normal looking set of startup messages,
Jan 27 10:46:03 LS09 kernel: ata1: SATA max UDMA/100 cmd 0xF8800080
ctl 0xF880008A bmdma 0xF8800010 irq 5
Jan 27 10:46:03 LS09 kernel: ata2: SATA max UDMA/100 cmd 0xF88000C0
ctl 0xF88000CA bmdma 0xF8800018 irq 5
Jan 27 10:46:03 LS09 kernel: ata3: SATA max UDMA/100 cmd 0xF8800280
ctl 0xF880028A bmdma 0xF8800210 irq 5
Jan 27 10:46:03 LS09 kernel: ata4: SATA max UDMA/100 cmd 0xF88002C0
ctl 0xF88002CA bmdma 0xF8800218 irq 5
Jan 27 10:46:03 LS09 kernel: ata1: dev 0 ATA-6, max UDMA/100,
625142448 sectors: LBA48
Jan 27 10:46:03 LS09 kernel: ata1: dev 0 configured for UDMA/100
Jan 27 10:46:03 LS09 kernel: scsi0 : sata_sil
Jan 27 10:46:03 LS09 kernel: ata2: dev 0 ATA-6, max UDMA/100,
625142448 sectors: LBA48
Jan 27 10:46:03 LS09 kernel: ata2: dev 0 configured for UDMA/100
Jan 27 10:46:03 LS09 kernel: scsi1 : sata_sil
Jan 27 10:46:03 LS09 kernel: ata3: dev 0 ATA-6, max UDMA/100,
625142448 sectors: LBA48
Jan 27 10:46:03 LS09 kernel: ata3: dev 0 configured for UDMA/100
Jan 27 10:46:03 LS09 kernel: scsi2 : sata_sil
Jan 27 10:46:03 LS09 kernel: ata4: dev 0 ATA-6, max UDMA/100,
625142448 sectors: LBA48
Jan 27 10:46:03 LS09 kernel: ata4: dev 0 configured for UDMA/100
Jan 27 10:46:03 LS09 kernel: scsi3 : sata_sil
Jan 27 10:46:03 LS09 kernel:   Vendor: ATA       Model: WDC
WD3200JD-00K  Rev: 08.0
Jan 27 10:46:03 LS09 kernel:   Type:   Direct-Access                  
   ANSI SCSI revision: 05
Jan 27 10:46:03 LS09 kernel:   Vendor: ATA       Model: WDC
WD3200JD-00K  Rev: 08.0
Jan 27 10:46:03 LS09 kernel:   Type:   Direct-Access                  
   ANSI SCSI revision: 05
Jan 27 10:46:03 LS09 kernel:   Vendor: ATA       Model: WDC
WD3200JD-00K  Rev: 08.0
Jan 27 10:46:03 LS09 kernel:   Type:   Direct-Access                  
   ANSI SCSI revision: 05
Jan 27 10:46:03 LS09 kernel:   Vendor: ATA       Model: WDC
WD3200JD-00K  Rev: 08.0
Jan 27 10:46:03 LS09 kernel:   Type:   Direct-Access                  
   ANSI SCSI revision: 05

Once I actually start doing output to with a drive I get these messages:
Jan 27 10:47:05 LS09 kernel: sdc: Current: sense key: No Sense
Jan 27 10:47:05 LS09 kernel:     Additional sense: No additional sense
information
Jan 27 10:47:06 LS09 kernel: sdb: Current: sense key: No Sense
Jan 27 10:47:06 LS09 kernel:     Additional sense: No additional sense
information
Jan 27 10:47:07 LS09 in.rshd[1607]: connect from root@128.1.50.1
Jan 27 10:47:07 LS09 rshd[1608]: root@JE-LS1 as root: cmd='/sbin/ifconfig'
Jan 27 10:47:08 LS09 kernel: sdc: Current: sense key: No Sense
Jan 27 10:47:08 LS09 kernel:     Additional sense: No additional sense
information
Jan 27 10:47:10 LS09 kernel: sdd: Current: sense key: No Sense
Jan 27 10:47:10 LS09 kernel:     Additional sense: No additional sense
information
Jan 27 10:47:10 LS09 kernel: sdb: Current: sense key: No Sense
Jan 27 10:47:10 LS09 kernel:     Additional sense: No additional sense
information
Jan 27 10:47:40 LS09 kernel: sd 1:0:0:0: SCSI error: return code = 0x8000002
Jan 27 10:47:40 LS09 kernel: sdb: Current: sense key: Aborted Command
Jan 27 10:47:40 LS09 kernel:     Additional sense: Scsi parity error
Jan 27 10:47:40 LS09 kernel: sdc: Current: sense key: No Sense
Jan 27 10:47:40 LS09 kernel:     Additional sense: No additional sense
information
Jan 27 10:48:10 LS09 kernel: sd 1:0:0:0: SCSI error: return code = 0x8000002
Jan 27 10:48:10 LS09 kernel: sdb: Current: sense key: Aborted Command
Jan 27 10:48:10 LS09 kernel:     Additional sense: Scsi parity error

next prev parent reply	other threads:[~2006-01-27 16:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-04  1:19 Jeff Garzik
2005-12-06 19:47 ` Richard Bollinger
2005-12-08 18:23   ` Thomas Backlund
2005-12-08 20:38     ` Jeff Garzik
2005-12-27 16:25       ` Thomas Backlund
2006-01-18  0:40         ` Jeff Garzik
2006-01-25 16:26           ` Bartlomiej Zolnierkiewicz
2006-01-27 16:29             ` Richard Bollinger [this message]
2005-12-07 12:35 ` Prakash Punnoor
     [not found] <5hAIO-6cQ-59@gated-at.bofh.it>
2006-01-26 14:50 ` Heikki Orsila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7744a2840601270829o135bb1c9ld0283042a0849abd@mail.gmail.com \
    --to=rabollinger@gmail.com \
    --cc=bzolnier@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tmb@mandriva.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®