mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "NG, TZE YEE" <tze.yee.ng@altera.com>
To: Dinh Nguyen <dinguyen@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "NG, ADRIAN HO YIN" <adrian.ho.yin.ng@altera.com>,
	"Nazle Asmade,
	Muhammad Nazim Amirul"
	<muhammad.nazim.amirul.nazle.asmade@altera.com>
Subject: Re: [PATCH 3/3] Fixes: 15847537b623 ("firmware: stratix10-rsu: Migrate RSU driver to use stratix10 asynchronous framework.")
Date: Fri, 15 May 2026 02:14:06 +0000	[thread overview]
Message-ID: <78ea7b06-4d3f-48ed-99c5-6b40d1a708f8@altera.com> (raw)
In-Reply-To: <bb1a6bd1-82a2-42cb-9217-c86d8269796a@kernel.org>

On 15/5/2026 1:18 am, Dinh Nguyen wrote:
> 
> 
> On 5/14/26 02:32, tze.yee.ng@altera.com wrote:
>> From: Tze Yee Ng <tze.yee.ng@altera.com>
>>
>> After stratix10_svc_add_async_client() succeeds, probe error paths and
>> remove() must call stratix10_svc_remove_async_client() before
>> stratix10_svc_free_channel(). Otherwise async state is left allocated
>> while the channel is released.
>>
>> Signed-off-by: Tze Yee Ng <tze.yee.ng@altera.com>
>> ---
>>   drivers/firmware/stratix10-rsu.c | 11 ++++++++++-
>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>
> 
> This is not the correct method for adding the Fixes tag. Please refer to:
> 
> Documentation/process/5.Posting.rst
> 
> Documentation/process/stable-kernel-rules.rst
> 
> Dinh
Submitted v2 to fix the commit title and move the fixes tag to the 
commit messages.

Thanks for review,
Regards,
Tze Yee

      reply	other threads:[~2026-05-15  2:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  7:32 [PATCH 0/3] firmware: stratix10-rsu: expose QSPI flash size and erase size from firmware tze.yee.ng
2026-05-14  7:32 ` [PATCH 1/3] Documentation: ABI: add stratix10-rsu QSPI size and erase_size sysfs tze.yee.ng
2026-05-14  7:32 ` [PATCH 2/3] firmware: stratix10-rsu: Add flash device info retrieval via SMC tze.yee.ng
2026-05-14  7:32 ` [PATCH 3/3] Fixes: 15847537b623 ("firmware: stratix10-rsu: Migrate RSU driver to use stratix10 asynchronous framework.") tze.yee.ng
2026-05-14 17:18   ` Dinh Nguyen
2026-05-15  2:14     ` NG, TZE YEE [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78ea7b06-4d3f-48ed-99c5-6b40d1a708f8@altera.com \
    --to=tze.yee.ng@altera.com \
    --cc=adrian.ho.yin.ng@altera.com \
    --cc=dinguyen@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muhammad.nazim.amirul.nazle.asmade@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®