From: Moussa Ba <moussa.a.ba@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, rientjes@google.com,
xiyou.wangcong@gmail.com, adobriyan@gmail.com, mpm@selenic.com,
mel@csn.ul.ie, yinghan@google.com, npiggin@suse.de,
jaredeh@gmail.com
Subject: Re: [PATCH 1/1] pagemap clear_refs: modify to specify anon or mapped vma clearing
Date: Tue, 28 Jul 2009 17:00:54 -0700 [thread overview]
Message-ID: <7928e7bd0907281700s13d9937yc3b2933b13cfae9f@mail.gmail.com> (raw)
In-Reply-To: <20090728165245.65d5cb23.akpm@linux-foundation.org>
The patch makes the clear_refs more versatile in adding the option to
select anonymous pages or file backed pages for clearing. This
addition has a measurable impact on user space application performance
as it decreases the number of pagewalks in scenarios where one is only
interested in a specific type of page (anonymous or file mapped).
On Tue, Jul 28, 2009 at 4:52 PM, Andrew Morton<akpm@linux-foundation.org> wrote:
> On Tue, 28 Jul 2009 15:52:05 -0700
> "Moussa A. Ba" <moussa.a.ba@gmail.com> wrote:
>
>> This patch adds anonymous and file backed filters to the clear_refs interface.
>> echo 1 > /proc/PID/clear_refs resets the bits on all pages
>> echo 2 > /proc/PID/clear_refs resets the bits on anonymous pages only
>> echo 3 > /proc/PID/clear_refs resets the bits on file backed pages only
>> Any other value is ignored
>
> The changelog is missing any rationale for making this change.
> Originally we were told that it "makes the clear_refs proc interface a
> bit more versatile", but that's a bit thin.
>
> How do we justify making this change to Linux? What value does it
> have? Can you describe a usage scenario which would help people
> understand the usefulness of the change?
>
> Thanks.
>
next prev parent reply other threads:[~2009-07-29 0:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 3:57 Moussa A. Ba
2009-07-24 8:39 ` Amerigo Wang
2009-07-24 18:00 ` Moussa Ba
2009-07-27 20:19 ` Moussa A. Ba
2009-07-27 20:30 ` Matt Mackall
2009-07-27 20:57 ` David Rientjes
2009-07-27 22:14 ` Moussa Ba
2009-07-27 22:20 ` Matt Mackall
2009-07-27 22:49 ` David Rientjes
2009-07-27 23:38 ` Moussa Ba
2009-07-27 23:42 ` Moussa Ba
2009-07-27 23:58 ` David Rientjes
2009-07-28 3:24 ` Amerigo Wang
2009-07-28 16:44 ` Moussa A. Ba
2009-07-28 21:01 ` David Rientjes
2009-07-28 22:52 ` Moussa A. Ba
2009-07-28 23:52 ` Andrew Morton
2009-07-29 0:00 ` Moussa Ba [this message]
2009-07-29 14:58 ` Mel Gorman
2009-07-29 16:41 ` Matt Mackall
2009-07-30 19:21 ` Moussa Ba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7928e7bd0907281700s13d9937yc3b2933b13cfae9f@mail.gmail.com \
--to=moussa.a.ba@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jaredeh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=mpm@selenic.com \
--cc=npiggin@suse.de \
--cc=rientjes@google.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®