From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info
Date: Wed, 7 Dec 2016 12:42:10 -0800 [thread overview]
Message-ID: <79b08015-4f9c-50cd-edc5-b89a15627fef@oracle.com> (raw)
In-Reply-To: <20161207.123642.1553217272033137094.davem@davemloft.net>
On 12/7/2016 9:36 AM, David Miller wrote:
[...]
> What does the newer tool do on an older kernel if it doesn't see
> the fields? Does it check the size of the structure given back
> to it, and conditionally handle the older vs. the newer layout?
>
> It must do this.
>
Right but the rds-tool doesn't handle it well and needs
to be fixed before this or any additional change in rds-info
structures. To handle the kernel struct size issues with its
user copy, there is a provision to probe kernel struct len
and then decide on layout buts its not used/implemented
in tools. The parsing comment I made is also not completely
accurate.
For now, I will drop this patch and submit it once the tools
code is fixed along with other used fields to handle both
layouts.
I should have checked the full compatibility matrix as you
commented. Sorry for oversight. Thanks for your comments Dave.
Regard,
Santosh
prev parent reply other threads:[~2016-12-07 20:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 4:01 [net-next][PATCH v2 00/18] net: RDS updates Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 01/18] RDS: log the address on bind failure Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 02/18] RDS: mark few internal functions static to make sparse build happy Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 03/18] RDS: IB: include faddr in connection log Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 04/18] RDS: IB: make the transport retry count smallest Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 05/18] RDS: RDMA: fix the ib_map_mr_sg_zbva() argument Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 06/18] RDS: RDMA: start rdma listening after init Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 07/18] RDS: RDMA: return appropriate error on rdma map failures Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 08/18] RDS: IB: split the mr registration and invalidation path Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 09/18] RDS: RDMA: silence the use_once mr log flood Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 10/18] RDS: IB: track and log active side endpoint in connection Santosh Shilimkar
2016-12-07 15:53 ` David Miller
2016-12-07 16:29 ` Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 11/18] RDS: IB: add few useful cache stasts Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 12/18] RDS: IB: Add vector spreading for cqs Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 13/18] RDS: RDMA: Fix the composite message user notification Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 14/18] RDS: IB: fix panic due to handlers running post teardown Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 15/18] RDS: add stat for socket recv memory usage Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 16/18] RDS: make message size limit compliant with spec Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 17/18] RDS: add receive message trace used by application Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info Santosh Shilimkar
2016-12-07 15:55 ` David Miller
2016-12-07 16:44 ` Santosh Shilimkar
2016-12-07 17:05 ` David Miller
2016-12-07 17:20 ` Santosh Shilimkar
2016-12-07 17:36 ` David Miller
2016-12-07 20:42 ` Santosh Shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79b08015-4f9c-50cd-edc5-b89a15627fef@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®