mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen Yu <yu.c.chen@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
	Len Brown <len.brown@intel.com>, Zhimin Gu <kookoo.gu@intel.com>,
	Yu Chen <yu.c.chen@intel.com>
Subject: [PATCH 10/12][RFC v3] x86-32, hibernate: Switch to relocated restore code during resume on 32bit system
Date: Wed, 19 Sep 2018 15:43:12 +0800	[thread overview]
Message-ID: <7a562ef6f77ff83c1fbdc6a2ecc7af387ce1fd71.1537275915.git.yu.c.chen@intel.com> (raw)
In-Reply-To: <cover.1537275915.git.yu.c.chen@intel.com>

From: Zhimin Gu <kookoo.gu@intel.com>

Code should be executed in a safe page during page
restoring, as the page where instruction is running
during resume might be scribbled and causes issues.

Backport the code from 64 bit system to fix this bug.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Signed-off-by: Zhimin Gu <kookoo.gu@intel.com>
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
---
 arch/x86/power/hibernate_32.c     | 4 ++++
 arch/x86/power/hibernate_asm_32.S | 7 +++++++
 2 files changed, 11 insertions(+)

diff --git a/arch/x86/power/hibernate_32.c b/arch/x86/power/hibernate_32.c
index a44bdada4e4e..a9861095fbb8 100644
--- a/arch/x86/power/hibernate_32.c
+++ b/arch/x86/power/hibernate_32.c
@@ -158,6 +158,10 @@ asmlinkage int swsusp_arch_resume(void)
 
 	temp_pgt = __pa(resume_pg_dir);
 
+	error = relocate_restore_code();
+	if (error)
+		return error;
+
 	/* We have got enough memory and from now on we cannot recover */
 	restore_image();
 	return 0;
diff --git a/arch/x86/power/hibernate_asm_32.S b/arch/x86/power/hibernate_asm_32.S
index 6b2b94937113..e9adda6b6b02 100644
--- a/arch/x86/power/hibernate_asm_32.S
+++ b/arch/x86/power/hibernate_asm_32.S
@@ -39,6 +39,13 @@ ENTRY(restore_image)
 	movl	restore_cr3, %ebp
 
 	movl	mmu_cr4_features, %ecx
+
+	/* jump to relocated restore code */
+	movl	relocated_restore_code, %eax
+	jmpl	*%eax
+
+/* code below has been relocated to a safe page */
+ENTRY(core_restore_code)
 	movl	temp_pgt, %eax
 	movl	%eax, %cr3
 
-- 
2.17.1


  parent reply	other threads:[~2018-09-19  7:36 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19  7:37 [PATCH 00/12][RFC v3] Backport several fixes from 64bits to 32bits hibernation Chen Yu
2018-09-19  7:37 ` [PATCH 01/12][RFC v3] x86, hibernate: Fix nosave_regions setup for hibernation Chen Yu
2018-09-19  8:34   ` Rafael J. Wysocki
2018-09-20 22:05   ` Pavel Machek
2018-09-19  7:38 ` [PATCH 02/12][RFC v3] PM / hibernate: Check the success of generating md5 digest before hibernation Chen Yu
2018-09-19  8:36   ` Rafael J. Wysocki
2018-09-20 22:05   ` Pavel Machek
2018-09-19  7:38 ` [PATCH 03/12][RFC v3] x86-32/asm/power: Create stack frames in hibernate_asm_32.S Chen Yu
2018-09-19  8:41   ` Rafael J. Wysocki
2018-09-19  8:54     ` Yu Chen
2018-09-19  7:38 ` [PATCH 04/12][RFC v3] x86, hibernate: Extract the common code of 64/32 bit system Chen Yu
2018-09-19  9:03   ` Rafael J. Wysocki
2018-09-19 10:15     ` Rafael J. Wysocki
2018-09-19 10:34     ` Ingo Molnar
2018-09-19 10:36       ` Rafael J. Wysocki
2018-09-20 22:05         ` Pavel Machek
2018-09-19  7:38 ` [PATCH 05/12][RFC v3] x86-32, hibernate: Enable CONFIG_ARCH_HIBERNATION_HEADER set on 32bit system Chen Yu
2018-09-19 10:31   ` Rafael J. Wysocki
2018-09-19  7:42 ` [PATCH 06/12][RFC v3] x86, hibernate: Rename temp_level4_pgt to temp_pgt Chen Yu
2018-09-20 22:05   ` Pavel Machek
2018-09-19  7:42 ` [PATCH 07/12][RFC v3] x86-32, hibernate: Use temp_pgt as the temporary page table Chen Yu
2018-09-20 22:05   ` Pavel Machek
2018-09-19  7:42 ` [PATCH 08/12][RFC v3] x86-32, hibernate: Use the page size macro instead of constant value Chen Yu
2018-09-20 22:05   ` Pavel Machek
2018-09-19  7:43 ` [PATCH 09/12][RFC v3] x86-32, hibernate: Switch to original page table after resumed Chen Yu
2018-09-20 22:05   ` Pavel Machek
2018-09-19  7:43 ` Chen Yu [this message]
2018-09-20 22:05   ` [PATCH 10/12][RFC v3] x86-32, hibernate: Switch to relocated restore code during resume on 32bit system Pavel Machek
2018-09-19  7:43 ` [PATCH 11/12][RFC v3] x86-32, hibernate: Set up temporary text mapping for " Chen Yu
2018-09-20 22:05   ` Pavel Machek
2018-09-19  7:43 ` [PATCH 12/12][RFC v3] x86-32, hibernate: Adjust in_suspend after resumed on " Chen Yu
2018-09-20 22:06   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a562ef6f77ff83c1fbdc6a2ecc7af387ce1fd71.1537275915.git.yu.c.chen@intel.com \
    --to=yu.c.chen@intel.com \
    --cc=kookoo.gu@intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®