From: Jens Axboe <axboe@kernel.dk>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: blk-tag: Replace GFP_ATOMIC with GFP_KERNEL in __blk_queue_init_tags
Date: Wed, 24 Jan 2018 20:44:26 -0700 [thread overview]
Message-ID: <7b20dc97-9240-726a-5664-c40c9421ef61@kernel.dk> (raw)
In-Reply-To: <1516851525-6828-1-git-send-email-baijiaju1990@gmail.com>
On 1/24/18 8:38 PM, Jia-Ju Bai wrote:
> After checking all possible call chains to kmalloc here,
> my tool finds that kmalloc is never called in atomic context.
> Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL.
>
> This is found by a static analysis tool named DCNS written by myself.
These two look OK to me, mostly. One issue is that blk_queue_init_tags()
can be used to resize tags, in which case it's called with the
queue lock held. Nobody is using it like that anymore, though. So I'd
prefer if you did a v2 of this patch, and include a correction to that
comment.
--
Jens Axboe
next prev parent reply other threads:[~2018-01-25 3:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 3:38 Jia-Ju Bai
2018-01-25 3:44 ` Jens Axboe [this message]
2018-01-25 8:03 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b20dc97-9240-726a-5664-c40c9421ef61@kernel.dk \
--to=axboe@kernel.dk \
--cc=baijiaju1990@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®