From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"shawn.sung@mediatek.corp-partner.google.com"
<shawn.sung@mediatek.corp-partner.google.com>
Subject: Re: [PATCH v4 4/5] drm/mediatek: Support "Pre-multiplied" blending in Mixer
Date: Wed, 17 Jul 2024 06:05:49 +0000 [thread overview]
Message-ID: <821bba3487d4433db05d8ed6817075b63ba4243f.camel@mediatek.com> (raw)
In-Reply-To: <20240717-alpha-blending-v4-4-4b1c806c0749@mediatek.com>
Hi, Shawn:
On Wed, 2024-07-17 at 13:24 +0800, Hsiao Chien Sung via B4 Relay wrote:
>
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> From: Hsiao Chien Sung <shawn.sung@mediatek.com>
>
> Support "Pre-multiplied" alpha blending mode in Mixer.
> Before this patch, only the coverage mode is supported.
>
> To replace the default setting that is set in mtk_ethdr_config(),
> we change mtk_ddp_write_mask() to mtk_ddp_write(), and this change will
> also reset the NON_PREMULTI_SOURCE bit that was assigned in
> mtk_ethdr_config(). Therefore, we must still set NON_PREMULTI_SOURCE bit
> if the blend mode is not DRM_MODE_BLEND_PREMULTI.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_ethdr.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/mediatek/mtk_ethdr.c
> index 80ccdad3741b..d1d9cf8b10e1 100644
> --- a/drivers/gpu/drm/mediatek/mtk_ethdr.c
> +++ b/drivers/gpu/drm/mediatek/mtk_ethdr.c
> @@ -36,6 +36,7 @@
> #define MIX_SRC_L0_ENBIT(0)
> #define MIX_L_SRC_CON(n)(0x28 + 0x18 * (n))
> #define NON_PREMULTI_SOURCE(2 << 12)
> +#define PREMULTI_SOURCE(3 << 12)
> #define MIX_L_SRC_SIZE(n)(0x30 + 0x18 * (n))
> #define MIX_L_SRC_OFFSET(n)(0x34 + 0x18 * (n))
> #define MIX_FUNC_DCM00x120
> @@ -176,6 +177,11 @@ void mtk_ethdr_layer_config(struct device *dev, unsigned int idx,
> alpha_con |= state->base.alpha & MIXER_ALPHA;
> }
>
> +if (state->base.pixel_blend_mode == DRM_MODE_BLEND_PREMULTI)
> +alpha_con |= PREMULTI_SOURCE;
> +else
> +alpha_con |= NON_PREMULTI_SOURCE;
> +
> if ((state->base.fb && !state->base.fb->format->has_alpha) ||
> state->base.pixel_blend_mode == DRM_MODE_BLEND_PIXEL_NONE) {
> /*
> @@ -193,8 +199,7 @@ void mtk_ethdr_layer_config(struct device *dev, unsigned int idx,
> mtk_ddp_write(cmdq_pkt, pending->height << 16 | align_width, &mixer->cmdq_base,
> mixer->regs, MIX_L_SRC_SIZE(idx));
> mtk_ddp_write(cmdq_pkt, offset, &mixer->cmdq_base, mixer->regs, MIX_L_SRC_OFFSET(idx));
> -mtk_ddp_write_mask(cmdq_pkt, alpha_con, &mixer->cmdq_base, mixer->regs, MIX_L_SRC_CON(idx),
> - 0x1ff);
> +mtk_ddp_write(cmdq_pkt, alpha_con, &mixer->cmdq_base, mixer->regs, MIX_L_SRC_CON(idx));
> mtk_ddp_write_mask(cmdq_pkt, BIT(idx), &mixer->cmdq_base, mixer->regs, MIX_SRC_CON,
> BIT(idx));
> }
>
> --
> 2.43.0
>
>
next prev parent reply other threads:[~2024-07-17 6:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 5:24 [PATCH v4 0/5] Support alpha blending in MTK display driver Hsiao Chien Sung via B4 Relay
2024-07-17 5:24 ` [PATCH v4 1/5] drm/mediatek: Support "None" blending in OVL Hsiao Chien Sung via B4 Relay
2024-07-17 13:49 ` AngeloGioacchino Del Regno
2024-07-17 5:24 ` [PATCH v4 2/5] drm/mediatek: Support "None" blending in Mixer Hsiao Chien Sung via B4 Relay
2024-07-17 5:58 ` CK Hu (胡俊光)
2024-07-17 5:24 ` [PATCH v4 3/5] drm/mediatek: Support "Pre-multiplied" blending in OVL Hsiao Chien Sung via B4 Relay
2024-07-17 13:49 ` AngeloGioacchino Del Regno
2024-07-17 5:24 ` [PATCH v4 4/5] drm/mediatek: Support "Pre-multiplied" blending in Mixer Hsiao Chien Sung via B4 Relay
2024-07-17 6:05 ` CK Hu (胡俊光) [this message]
2024-07-17 5:24 ` [PATCH v4 5/5] drm/mediatek: Support alpha blending in display driver Hsiao Chien Sung via B4 Relay
2024-07-31 13:34 ` [PATCH v4 0/5] Support alpha blending in MTK " Chun-Kuang Hu
2024-08-02 1:25 ` Shawn Sung (宋孝謙)
2024-09-12 20:29 ` Alper Nebi Yasak
2024-09-13 1:25 ` CK Hu (胡俊光)
2024-09-13 2:56 ` Jason-JH Lin (林睿祥)
2024-09-13 5:40 ` Alper Nebi Yasak
2024-09-13 9:01 ` AngeloGioacchino Del Regno
2024-09-14 20:22 ` Jason-JH Lin (林睿祥)
2024-09-15 10:30 ` Shawn Sung (宋孝謙)
2024-09-13 2:56 ` Shawn Sung (宋孝謙)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=821bba3487d4433db05d8ed6817075b63ba4243f.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=Shawn.Sung@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=shawn.sung@mediatek.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®