Re: [PATCH 6/6] x86: add KERN_APIC

["Yinghai Lu" <yhlu.kernel@gmail.com>]

On Wed, Sep 17, 2008 at 5:08 AM, Frans Pop <elendil@planet.nl> wrote:
> Yinghai Lu wrote:
>> On Wed, Sep 17, 2008 at 1:38 AM, Ingo Molnar <mingo@elte.hu> wrote:
>>>> -             printk(KERN_WARNING "APIC calibration not consistent "
>>>> +             printk(KERN_WARNING KERN_APIC "APIC calibration not
>>>> consistent "
>>>
>>> here too the question arises: what should the semantics of the 'mixing'
>>> of such subsystem printk tags with the classic priority tags be. I
>>> think in this particular case we dont want the KERN_APIC tag, as that
>>> would prevent this failure message to be printed by default. I.e. this
>>> line should remain:
>>>
>>>> -             printk(KERN_WARNING "APIC calibration not consistent "
>>>
>>> to make sure this warning always shows up in the logs. Agreed?
>>
>> with
>> DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 6);
>> the KERN_WARNING <5> will be showing up that warning, even without
>> loglevl=apic:8
>>
>> or change that  to
>> DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 7);
>
> Are you suggesting that each subsystem define its own default log level?
> That sounds truly horrible. It would mean that when reading code or
> adding new messages you'd always have to check what the default loglevel
> is for a particular subsystem.

could be done.
SPEW: 8
???:9

current msg_loglevel is limted to one digital

YH