mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chang S. Bae" <chang.seok.bae@intel.com>
To: Dave Hansen <dave.hansen@intel.com>, <len.brown@intel.com>,
	<tony.luck@intel.com>, <rafael.j.wysocki@intel.com>,
	<reinette.chatre@intel.com>, <dan.j.williams@intel.com>
Cc: <corbet@lwn.net>, <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Documentation/x86: Add the AMX enabling example
Date: Fri, 17 Jun 2022 14:35:28 -0700	[thread overview]
Message-ID: <86952726-53e6-17a9-dbe0-3e970c565044@intel.com> (raw)
In-Reply-To: <d8278c53-71fd-3400-9ba6-079c99d66645@intel.com>

On 6/16/2022 3:45 PM, Dave Hansen wrote:
>> +  1. **Check the feature availability**. AMX_TILE is enumerated in CPUID
>> +     leaf 7, sub-leaf 0, bit 24 of EDX. If available, ``/proc/cpuinfo``
>> +     shows ``amx_tile`` in the flag entry of the CPUs.  Given that, the
>> +     kernel may have set XSTATE component 18 in the XCR0 register. But a
>> +     user needs to ensure the kernel support via the ARCH_GET_XCOMP_SUPP
>> +     option::
> 
> Why did you bother mentioning the XCR0 and CPUID specifics?  We don't
> want applications doing that, right?

Without checking them, this arch_prctl(2) option can be tried. Then it 
will return either EINVAL or the feature bit off if unavailable. Yes, 
that's all wanted instead of that old way. So maybe something like this 
here:

	An application first needs to determine the feature support:

> 
>> +        #include <asm/prctl.h>
>> +        #include <sys/syscall.h>
>> +	#include <stdio.h>
>> +        #include <unistd.h>
> 
> ^ Just from the appearance here there looks to be some spaces vs. tabs
> inconsistency.

Sorry, a tab instead of spaces was added later to fix a compile error.

<snip>

>> +  2. **Request permission**. Now it is found that the kernel supports the
>> +     feature. But the permission is not automatically given. A user needs
>> +     to explicitly request it via the ARCH_REQ_XCOMP_PERM option::
> 
> That phrasing is a bit awkward.  How about:
> 
> 	After determining support for AMX, an application must
> 	explicitly ask permission to use it:
> 	...

Yeah, looks to be concise. Thanks!

Chang

  reply	other threads:[~2022-06-17 21:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 21:22 [PATCH 0/2] Documentation/x86: Update the dynamic XSTATE doc Chang S. Bae
2022-06-16 21:22 ` [PATCH 1/2] Documentation/x86: Add the AMX enabling example Chang S. Bae
2022-06-16 22:45   ` Dave Hansen
2022-06-17 21:35     ` Chang S. Bae [this message]
2022-08-24  4:33   ` Bagas Sanjaya
2022-06-16 21:22 ` [PATCH 2/2] Documentation/x86: Explain guest XSTATE permission control Chang S. Bae
2022-06-16 22:49   ` Dave Hansen
2022-06-23 23:55     ` Chang S. Bae
2022-08-23 23:34       ` Chang S. Bae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86952726-53e6-17a9-dbe0-3e970c565044@intel.com \
    --to=chang.seok.bae@intel.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=reinette.chatre@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®