From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754211AbcBAMhv (ORCPT ); Mon, 1 Feb 2016 07:37:51 -0500 Received: from canardo.mork.no ([148.122.252.1]:48580 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753671AbcBAMhu convert rfc822-to-8bit (ORCPT ); Mon, 1 Feb 2016 07:37:50 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Mathieu OTHACEHE Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 11/14] USB: serial: mos7840: move constants to right Organization: m References: <1454175887-16158-1-git-send-email-m.othacehe@gmail.com> <1454175887-16158-12-git-send-email-m.othacehe@gmail.com> <87zivltovx.fsf@nemi.mork.no> <20160201115706.GA13635@gmail.com> Date: Mon, 01 Feb 2016 13:37:33 +0100 In-Reply-To: <20160201115706.GA13635@gmail.com> (Mathieu OTHACEHE's message of "Mon, 1 Feb 2016 12:57:06 +0100") Message-ID: <871t8wa9o2.fsf@nemi.mork.no> User-Agent: Gnus/5.130013 (Ma Gnus v0.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mathieu OTHACEHE writes: > On Sun, Jan 31, 2016 at 10:33:54PM +0100, Bjørn Mork wrote: > >> I feel I'm missing something here, so I have to ask the stupid question: >> What could possibly be the benefit here? Is it faster? Safer? Easier >> to read? > > I don't think it will be faster or safer, maybe easier to read. But the point is to remove the > warnings produced by the file scripts/coccinelle/misc/compare_const_fl.cocci when > running make coccicheck. Making a tool happy is never going to be a valid reason for anything. If it were, then you would not be necessary... Luckily you still are. Your task is adding some intelligence to the output of the script. That means that you should look at the output and describe how it improves the code in a way that makes me understand it. And I can be pretty slow :) If you can't do that, then there is a high probability that the script didn't improve anything. Bjørn