From: Tomasz Maciej Nowak <tmn505@gmail.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux@armlinux.org.uk,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dtc: tegra: enable front panel leds in TrimSlice
Date: Wed, 21 Feb 2018 17:20:14 +0100 [thread overview]
Message-ID: <873b01dc-3ca5-3151-2654-a8272cb9dd88@gmail.com> (raw)
In-Reply-To: <57945bd2-d8c2-f7bc-f01f-29d679762446@wwwdotorg.org>
W dniu 20.02.2018 o 20:55, Stephen Warren pisze:
> On 02/19/2018 01:16 PM, Tomasz Maciej Nowak wrote:
>> Adds device nodes for two front panel LEDs.
>
> Why do you need to change the pinmux settings? Configuring a pin as a
> GPIO should override any pinmux special function selection and hence
> make it irrelevant, so I don't think you should need to change the pinmux.
At first I did exactly that without changing the pinmux, but the LEDs
didn't light up. After that I compared with CompuLab source tree [1].
The pinmux was specified as in my patch. With this change the LEDs are
fully functional.
1.
https://gitorious.org/trimslice-kernel/trimslice-kernel?p=trimslice-kernel:trimslice-kernel.git;a=blob;f=arch/arm/mach-tegra/board-trimslice-pinmux.c;h=cc6d5225d97eb9327c820bf1d5b2bc16ab8c6dda;hb=d25bf45d6314089489b30d218ed8a0d6d94417f9#l45
--
Tomek
next prev parent reply other threads:[~2018-02-21 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 20:16 Tomasz Maciej Nowak
2018-02-20 19:55 ` Stephen Warren
2018-02-21 16:20 ` Tomasz Maciej Nowak [this message]
2018-02-21 16:46 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873b01dc-3ca5-3151-2654-a8272cb9dd88@gmail.com \
--to=tmn505@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®