From: Andreas Hindborg <a.hindborg@kernel.org>
To: Adarsh Das <adarshdas950@gmail.com>, adarshdas950@gmail.com
Cc: acourbot@nvidia.com, aliceryhl@google.com, axboe@kernel.dk,
bjorn3_gh@protonmail.com, boqun@kernel.org, dakr@kernel.org,
daniel.almeida@collabora.com, gary@garyguo.net,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
lossin@kernel.org, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, tamird@kernel.org,
tmgross@umich.edu, work@onurozkan.dev
Subject: Re: [PATCH v3] rust: block: set GenDisk block_device_operations.owner to THIS_MODULE
Date: Wed, 23 Sep 2026 22:31:50 +0200 [thread overview]
Message-ID: <87cxu33e15.fsf@t14s.mail-host-address-is-not-set> (raw)
In-Reply-To: <87fqyz3etf.fsf@t14s.mail-host-address-is-not-set>
Andreas Hindborg <a.hindborg@kernel.org> writes:
> Hi Adarsh,
>
> Adarsh Das <adarshdas950@gmail.com> writes:
>
>> GenDiskBuilder left block_device_operations.owner NULL. Set owner from a
>> const block_device_operations table using this_module::<M>() and update
>> rnull to pass NullBlkModule.
>>
>> Add ModuleMetadata::THIS_MODULE and this_module() so the owner pointer is
>> available in const context. Rebased on Alvins fix-fops-owner series [1].
>>
>> Link: https://lore.kernel.org/all/20260805192020.107601-1-adarshdas950@gmail.com/
>>
>
> We merged `LocalModule` [1]. Please use this feature to set the owner.
>
> I don't think you need to move the operations vtable.
>
> Best regards,
> Andreas Hindborg
>
> [1] https://lore.kernel.org/r/20260811-fix-fops-owner-v10-7-7e71776f9dbe@linux.dev
Actually we are going to pick this one instead [1]. Seems like you have
been trying to do the same thing.
Best regards,
Andreas Hindborg
[1] https://lore.kernel.org/r/20260811-fix-gendisk-owner-v1-1-c0fe4a449ecb@linux.dev
prev parent reply other threads:[~2026-09-23 20:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 19:20 [PATCH] " Adarsh Das
2026-08-06 8:36 ` [PATCH v2] " Adarsh Das
2026-08-06 9:08 ` Andreas Hindborg
2026-08-06 10:40 ` [PATCH v3] " Adarsh Das
2026-09-23 20:14 ` Andreas Hindborg
2026-09-23 20:31 ` Andreas Hindborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cxu33e15.fsf@t14s.mail-host-address-is-not-set \
--to=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=adarshdas950@gmail.com \
--cc=aliceryhl@google.com \
--cc=axboe@kernel.dk \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®