From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-43170.protonmail.ch (mail-43170.protonmail.ch [185.70.43.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36D7B2367DF for ; Mon, 21 Sep 2026 05:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789968643; cv=none; b=EOlcEjCvvt7XbKXRVZCrBs11J12Bsy3pexFBOE5c9QVq2fFoCKvK+eWZM6GTH/K4JQj4LcRv6h8Up6wyrJIHdl4H0wFpPfrx+qYWht9jVxfVKPWAUodAlqFF0v+iZe46cnmJrUr7ihsiRgE+cpHDDjTrAKcyGQe5vFFVtCNcmFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789968643; c=relaxed/simple; bh=+GFyEruLPpVHhivtOE/9dTjxf+78VADPZmw++4Vb7LY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=aok99twqiOmg3RxEDiFP3ypomkpmPDIyV7uZc9W7M5HvT+rg+s1Q18vDF0Z24wKWV+pj+JnNSb5JDYdRbxBXe7NuDxz3G+tKSMU+T4mEmVOREAv1iJ9dg9NL6+0XQKDMpf13Ih7cODM4RYJiwapPwuN+pVIhZ34a1N5gkdca2ts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com; spf=pass smtp.mailfrom=geanix.com; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b=kE2KZl1I; arc=none smtp.client-ip=185.70.43.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=geanix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="kE2KZl1I" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=geanix.com; s=protonmail; t=1789968630; x=1790227830; bh=i2wIboFCo+kxs04aAU6+cy0CY230tavUIgMU5s1ifaQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=kE2KZl1IXAuYSx8USsyxZrbIA3M82psf3fGpdj2RAHJt8si+YKLfsPSCR2KGVeduf cFfSl1Xq694rkdQrEaOIDODL5gJRkjzb1Va+BCbI253DdDAZVD+ozu82O948Sc3uNr 57ktxsAHz+mFtgTvvwW9u4cyHFQH4DaA2Kg87c4ZNSRLgoRBialP7RFfMdmuZquV93 DsRWJuvWyDLBccb9P8NjoZ6ujBJUSeQUpdYVZSMSZeUtxinlZJC2UYUSHHg64Tiebt WFl5Z6MwCFgfkEYexqnTAzOUQ6sXgqahTVRZRfAzZ6WsVSJ/KN/SdPdQcJ0sTHkw1l gx+3nedQQ7h8A== X-Pm-Submission-Id: 4hpBdd10M2z1DDrL From: Esben Haabendal To: "Jonathan Cameron" Cc: "Lars-Peter Clausen" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Martin Kepplinger" , "Sean Nyekjaer" , "David Lechner" , Nuno =?utf-8?Q?S=C3=A1?= , "Andy Shevchenko" , "Martin Kepplinger" , "Christoph Muellner" , , , , "Joshua Crofts" Subject: Re: [PATCH v9 07/10] iio: accel: mma8452: Add comment block for struct mma8452_data In-Reply-To: <178995195773.928090.4574643769779647971.b4-review@b4> References: <20260916-mma8452-open-drain-v9-0-0dd24fa2f3d7@geanix.com> <20260916-mma8452-open-drain-v9-7-0dd24fa2f3d7@geanix.com> <178995195773.928090.4574643769779647971.b4-review@b4> Date: Mon, 21 Sep 2026 07:30:28 +0200 Message-ID: <87fqz39nnv.fsf@geanix.com> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Jonathan Cameron" writes: >> The struct mma8452_data is central for this driver, and it makes sense to >> have a description of the fields in it to make it easier to work with the >> driver. >> >> Reviewed-by: Joshua Crofts >> Signed-off-by: Esben Haabendal >> >> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c >> index b70bc8638128..223bef4f7baf 100644 >> --- a/drivers/iio/accel/mma8452.c >> +++ b/drivers/iio/accel/mma8452.c >> @@ -104,6 +104,21 @@ >> >> #define MMA8452_AUTO_SUSPEND_DELAY_MS 2000 >> >> +/** >> + * struct mma8452_data - IIO device private data structure >> + * @client: the I2C client object >> + * @lock: mutex for synchronziation of register > > From sashiko. > [Severity: Low] > This isn't a bug, but there's a typo here (synchronziation). > - > If nothing else shows up I'll fix it up whilst applying. I will fix it in v10. /Esben