From: John Ogness <john.ogness@linutronix.de>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Gabriele Monaco <gmonaco@redhat.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
bpf@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Cc: Nam Cao <namcao@linutronix.de>, Wen Yang <wen.yang@linux.dev>,
Tobias Schaffner <tobias.schaffner@siemens.com>,
Viktor Malik <vmalik@redhat.com>
Subject: Re: [PATCH v2 10/15] tools/rv: Add BPF monitors
Date: Sun, 18 Oct 2026 14:16:03 +0206 [thread overview]
Message-ID: <87ik2zryzo.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <DM7I2PYHNKXE.3AYY3N1HATXLW@gmail.com>
On 2026-10-17, "Alexei Starovoitov" <alexei.starovoitov@gmail.com> wrote:
> On Sat, Oct 17, 2026 at 07:02 PM John Ogness <john.ogness@linutronix.de> wrote:
>> It would be nice if it could be filtered so that only RV violation
>> bpf_printk's would trigger. I do not think it is possible for a filter
>> to do primitive pattern matching on @bpf_string. Or am I wrong?
>
> not an ftrace expert, but it should be possible. bpf_string is
> a dynamic string field and filters take globs on those.
Yes, indeed this works. Thanks for mentioning the globs.
>> With the "new" ringbuffer and nbcon implementations, it no longer dos-es
>> the kernel, so I have no problem with bpf programs calling
>> printk_deferred(). And besides, userspace can already blast the
>> ringbuffer and consoles via /dev/kmsg.
>
> well, /dev/kmsg is ratelimited unless printk.devkmsg=on,
> but the kfunc wouldn't be.
> I still feel that bpf_stream + user space that writes into
> /dev/kmsg is a better design.
My issue with the /dev/kmsg design is bogus timestamps. But let's just
drop my suggestion to allow eBPF programs to call printk(). Since the RV
move to eBPF will require new user workflows anyway, the users will need
to learn these new packages, tools, and output sources. The important
thing (for me) is RV violations can still be used effectively with
ftrace/perf, which they can (using globs in bpf_trace:bpf_trace_printk
filters).
@gmonaco: There should be clean glob-friendly RV bpf_trace_printk
strings so that filters can be easily and reliably set up.
John
next prev parent reply other threads:[~2026-10-18 12:10 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 15:20 [PATCH v2 00/15] rv: Add support for " Gabriele Monaco
2026-10-01 15:20 ` [PATCH v2 01/15] sched: Add task enqueue/dequeue trace points Gabriele Monaco
2026-10-01 15:49 ` Peter Zijlstra
2026-10-02 7:09 ` Gabriele Monaco
2026-10-02 10:29 ` Peter Zijlstra
2026-10-02 11:55 ` Gabriele Monaco
2026-10-02 19:18 ` Peter Zijlstra
2026-10-02 19:40 ` Gabriele Monaco
2026-10-04 7:57 ` Steven Rostedt
2026-10-12 11:54 ` Peter Zijlstra
2026-10-04 7:45 ` Steven Rostedt
2026-10-12 11:49 ` Peter Zijlstra
2026-10-02 0:42 ` bot+bpf-ci
2026-10-01 15:20 ` [PATCH v2 02/15] tools/rv: Skip empty pid error in selftest if command failed Gabriele Monaco
2026-10-02 0:42 ` bot+bpf-ci
2026-10-01 15:20 ` [PATCH v2 03/15] rv: Refactor da_trace() functions to get strings internally Gabriele Monaco
2026-10-01 15:20 ` [PATCH v2 04/15] rv: Cast result of model_get_*_name() Gabriele Monaco
2026-10-13 6:14 ` Nam Cao
2026-10-13 8:15 ` Gabriele Monaco
2026-10-14 9:52 ` Gabriele Monaco
2026-10-14 10:02 ` Nam Cao
2026-10-01 15:20 ` [PATCH v2 05/15] tools/rv: Move argument parsing from in_kernel to utils Gabriele Monaco
2026-10-02 0:25 ` bot+bpf-ci
2026-10-01 15:20 ` [PATCH v2 06/15] tools/build: Add a feature test for bpftool-btf Gabriele Monaco
2026-10-01 15:20 ` [PATCH v2 07/15] tools/rv: Implement BPF monitor discovery and listing Gabriele Monaco
2026-10-02 0:42 ` bot+bpf-ci
2026-10-01 15:20 ` [PATCH v2 08/15] tools/rv: Implement BPF monitor loading and tracing Gabriele Monaco
2026-10-02 0:43 ` bot+bpf-ci
2026-10-01 15:20 ` [PATCH v2 09/15] tools/rv: Copy stripped bpf_atomic.h from libarena Gabriele Monaco
2026-10-02 0:42 ` bot+bpf-ci
2026-10-07 12:59 ` Nam Cao
2026-10-08 9:00 ` Gabriele Monaco
2026-10-08 11:16 ` Nam Cao
2026-10-09 10:09 ` Gabriele Monaco
2026-10-11 0:43 ` Steven Rostedt
2026-10-12 7:43 ` Gabriele Monaco
2026-10-01 15:20 ` [PATCH v2 10/15] tools/rv: Add BPF monitors Gabriele Monaco
2026-10-02 0:43 ` bot+bpf-ci
2026-10-06 13:29 ` Alexei Starovoitov
2026-10-08 9:54 ` Gabriele Monaco
2026-10-16 18:32 ` Alexei Starovoitov
2026-10-16 19:20 ` John Ogness
2026-10-17 10:42 ` Gabriele Monaco
2026-10-17 15:17 ` John Ogness
2026-10-17 16:09 ` Alexei Starovoitov
2026-10-17 16:56 ` John Ogness
2026-10-17 23:25 ` Alexei Starovoitov
2026-10-18 12:10 ` John Ogness [this message]
2026-10-17 10:48 ` Gabriele Monaco
2026-10-01 15:20 ` [PATCH v2 11/15] tools/rv: Define CONFIG_X86_64 statically for " Gabriele Monaco
2026-10-01 15:20 ` [PATCH v2 12/15] tools/rv: Add reactors support to " Gabriele Monaco
2026-10-02 0:43 ` bot+bpf-ci
2026-10-01 15:20 ` [PATCH v2 13/15] verification/rvgen: Add support for " Gabriele Monaco
2026-10-02 0:25 ` bot+bpf-ci
2026-10-01 15:20 ` [PATCH v2 14/15] tools/rv: Add selftest for rv bpf monitors Gabriele Monaco
2026-10-02 0:43 ` bot+bpf-ci
2026-10-01 15:20 ` [PATCH v2 15/15] verification/rvgen: Add selftest for rvgen -b Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik2zryzo.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=rostedt@goodmis.org \
--cc=tobias.schaffner@siemens.com \
--cc=vmalik@redhat.com \
--cc=wen.yang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®