mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: <netdev@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org,
	"Ben Hutchings" <ben@decadent.org.uk>,
	"Christian Riesch" <christian.riesch@omicron.at>,
	"David Miller" <davem@davemloft.net>,
	"Stefan Sørensen" <stefan.sorensen@spectralink.com>
Subject: [PATCH net-next v3 5/9] dp83640: trivial fixes
Date: Thu, 20 Mar 2014 22:21:56 +0100	[thread overview]
Message-ID: <880b3d42ed128501863528e4acac85fe652b5259.1395350113.git.richardcochran@gmail.com> (raw)
In-Reply-To: <cover.1395350105.git.richardcochran@gmail.com>

This patch cleans up the input checking code on the external time stamp
function by using an unsigned rather than a signed channel index.

Also, this patch corrects the author's email address. When this macro
was last changed, the top level domain part of the email address was
left behind.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
 drivers/net/phy/dp83640.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index 98e7cbf..d6c1061 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -424,13 +424,13 @@ static int ptp_dp83640_enable(struct ptp_clock_info *ptp,
 	struct dp83640_clock *clock =
 		container_of(ptp, struct dp83640_clock, caps);
 	struct phy_device *phydev = clock->chosen->phydev;
-	int index;
+	unsigned int index;
 	u16 evnt, event_num, gpio_num;
 
 	switch (rq->type) {
 	case PTP_CLK_REQ_EXTTS:
 		index = rq->extts.index;
-		if (index < 0 || index >= N_EXT_TS)
+		if (index >= N_EXT_TS)
 			return -EINVAL;
 		event_num = EXT_EVENT + index;
 		evnt = EVNT_WR | (event_num & EVNT_SEL_MASK) << EVNT_SEL_SHIFT;
@@ -1363,7 +1363,7 @@ static void __exit dp83640_exit(void)
 }
 
 MODULE_DESCRIPTION("National Semiconductor DP83640 PHY driver");
-MODULE_AUTHOR("Richard Cochran <richardcochran@gmail.at>");
+MODULE_AUTHOR("Richard Cochran <richardcochran@gmail.com>");
 MODULE_LICENSE("GPL");
 
 module_init(dp83640_init);
-- 
1.7.10.4


  parent reply	other threads:[~2014-03-20 21:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 21:21 [PATCH net-next v3 0/9] ptp: dynamic pin control Richard Cochran
2014-03-20 21:21 ` [PATCH net-next v3 1/9] ptp: introduce programmable pins Richard Cochran
2014-03-20 21:21 ` [PATCH net-next v3 2/9] ptp: add the pin GET/SETFUNC ioctls to the testptp program Richard Cochran
2014-03-20 21:21 ` [PATCH net-next v3 3/9] ptp: expose the programmable pins via sysfs Richard Cochran
2014-03-20 21:21 ` [PATCH net-next v3 4/9] ptp: drivers: set the number of programmable pins Richard Cochran
2014-03-21  8:02   ` Jeff Kirsher
2014-03-20 21:21 ` Richard Cochran [this message]
2014-03-20 21:21 ` [PATCH net-next v3 6/9] dp83640: correct the periodic output frequency Richard Cochran
2014-03-20 21:21 ` [PATCH net-next v3 7/9] dp83640: implement programmable pin functions Richard Cochran
2014-03-20 21:21 ` [PATCH net-next v3 8/9] dp83640: let external input pins from the module parameters be defaults Richard Cochran
2014-03-20 21:22 ` [PATCH net-next v3 9/9] dp83640: let the periodic pin from the module parameter be a default Richard Cochran
2014-03-21 18:22 ` [PATCH net-next v3 0/9] ptp: dynamic pin control David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=880b3d42ed128501863528e4acac85fe652b5259.1395350113.git.richardcochran@gmail.com \
    --to=richardcochran@gmail.com \
    --cc=ben@decadent.org.uk \
    --cc=christian.riesch@omicron.at \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefan.sorensen@spectralink.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®