mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Matthew Garrett <mjg@redhat.com>,
	Cezary Jackiewicz <cezary.jackiewicz@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 05/23] compal-laptop: Convert printks to pr_<level>
Date: Tue, 29 Mar 2011 15:21:36 -0700	[thread overview]
Message-ID: <884fbb2e33c99f00d795a9c360fef46da6ddfcb7.1301436234.git.joe@perches.com> (raw)
In-Reply-To: <cover.1301436234.git.joe@perches.com>

Add pr_fmt.
Convert printks to pr_<level> removing DRIVER_NAME prefix.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/platform/x86/compal-laptop.c |   22 +++++++++-------------
 1 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c
index c16a276..4c4a742 100644
--- a/drivers/platform/x86/compal-laptop.c
+++ b/drivers/platform/x86/compal-laptop.c
@@ -68,6 +68,8 @@
  * only enabled on a JHL90 board until it is verified that they work on the
  * other boards too.  See the extra_features variable. */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
@@ -760,16 +762,14 @@ static struct rfkill *bt_rfkill;
 
 static int dmi_check_cb(const struct dmi_system_id *id)
 {
-	printk(KERN_INFO DRIVER_NAME": Identified laptop model '%s'\n",
-		id->ident);
+	pr_info("Identified laptop model '%s'\n", id->ident);
 	extra_features = false;
 	return 1;
 }
 
 static int dmi_check_cb_extra(const struct dmi_system_id *id)
 {
-	printk(KERN_INFO DRIVER_NAME": Identified laptop model '%s', "
-		"enabling extra features\n",
+	pr_info("Identified laptop model '%s', enabling extra features\n",
 		id->ident);
 	extra_features = true;
 	return 1;
@@ -956,14 +956,12 @@ static int __init compal_init(void)
 	int ret;
 
 	if (acpi_disabled) {
-		printk(KERN_ERR DRIVER_NAME": ACPI needs to be enabled for "
-						"this driver to work!\n");
+		pr_err("ACPI needs to be enabled for this driver to work!\n");
 		return -ENODEV;
 	}
 
 	if (!force && !dmi_check_system(compal_dmi_table)) {
-		printk(KERN_ERR DRIVER_NAME": Motherboard not recognized (You "
-				"could try the module's force-parameter)");
+		pr_err("Motherboard not recognized (You could try the module's force-parameter)\n");
 		return -ENODEV;
 	}
 
@@ -998,8 +996,7 @@ static int __init compal_init(void)
 	if (ret)
 		goto err_rfkill;
 
-	printk(KERN_INFO DRIVER_NAME": Driver "DRIVER_VERSION
-						" successfully loaded\n");
+	pr_info("Driver " DRIVER_VERSION " successfully loaded\n");
 	return 0;
 
 err_rfkill:
@@ -1064,7 +1061,7 @@ static void __exit compal_cleanup(void)
 	rfkill_destroy(wifi_rfkill);
 	rfkill_destroy(bt_rfkill);
 
-	printk(KERN_INFO DRIVER_NAME": Driver unloaded\n");
+	pr_info("Driver unloaded\n");
 }
 
 static int __devexit compal_remove(struct platform_device *pdev)
@@ -1074,8 +1071,7 @@ static int __devexit compal_remove(struct platform_device *pdev)
 	if (!extra_features)
 		return 0;
 
-	printk(KERN_INFO DRIVER_NAME": Unloading: resetting fan control "
-							"to motherboard\n");
+	pr_info("Unloading: resetting fan control to motherboard\n");
 	pwm_disable_control();
 
 	data = platform_get_drvdata(pdev);
-- 
1.7.4.2.g597a6.dirty


  parent reply	other threads:[~2011-03-29 22:22 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29 22:21 [PATCH 00/23] drivers/platform/x86: Remove warnings and use pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 01/23] asus-wmi: Remove __init from asus_wmi_platform_init Joe Perches
2011-03-31  7:17   ` Corentin Chary
2011-03-29 22:21 ` [PATCH 02/23] ibm_rtl: Remove warnings from casts of pointer to int Joe Perches
2011-03-29 22:21 ` [PATCH 03/23] acer-wmi: pr_<level> cleanups Joe Perches
2011-03-31  6:41   ` Joey Lee
2011-03-29 22:21 ` [PATCH 04/23] asus: Add pr_fmt and convert printks to pr_<level> Joe Perches
2011-03-31  7:18   ` Corentin Chary
2011-03-29 22:21 ` Joe Perches [this message]
2011-03-29 22:21 ` [PATCH 06/23] dell: Convert " Joe Perches
2011-03-29 22:21 ` [PATCH 07/23] eeepc: Use pr_warn Joe Perches
2011-03-31  7:19   ` Corentin Chary
2011-03-29 22:21 ` [PATCH 08/23] fujitsu-laptop: Convert printks to pr_<level> Joe Perches
2011-03-29 22:42   ` Jonathan Woithe
2011-03-29 22:50     ` Joe Perches
2011-03-29 22:21 ` [PATCH 09/23] hdaps: " Joe Perches
2011-03-30  1:54   ` Lucas De Marchi
2011-03-30  2:00     ` Joe Perches
2011-03-29 22:21 ` [PATCH 10/23] hp-wmi: " Joe Perches
2011-03-29 22:21 ` [PATCH 11/23] ibm_rtl: Use pr_fmt and pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 12/23] ideapad-laptop: Add pr_fmt Joe Perches
2011-03-29 22:21 ` [PATCH 13/23] intel_menlow: Add pr_fmt and use pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 14/23] intel_pmic_gpio: Convert printks to pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 15/23] msi-laptop: pr_<level> neatening Joe Perches
2011-03-31  6:41   ` Joey Lee
2011-03-29 22:21 ` [PATCH 16/23] msi-wmi: Use pr_fmt and pr_<level> Joe Perches
2011-03-30 14:16   ` Anisse Astier
2011-03-29 22:21 ` [PATCH 17/23] sony-laptop: Add and use #define pr_fmt Joe Perches
2011-03-29 22:21 ` [PATCH 18/23] tc1100-wmi: Add pr_fmt, use pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 19/23] thinkpad_acpi: Convert printks to pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 20/23] topstar-laptop: Convert remaining printk to pr_info Joe Perches
2011-03-29 23:44   ` Herton Ronaldo Krzesinski
2011-03-29 22:21 ` [PATCH 21/23] toshiba: Convert printks to pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 22/23] wmi: Removed trailing whitespace from logging message Joe Perches
2011-03-29 22:21 ` [PATCH 23/23] xo15-ebook: Use pr_<level> Joe Perches
2011-03-30 14:30 ` [PATCH 00/23] drivers/platform/x86: Remove warnings and use pr_<level> Corentin Chary
2011-03-30 15:02   ` Joe Perches
2011-04-01 18:21 ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=884fbb2e33c99f00d795a9c360fef46da6ddfcb7.1301436234.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=cezary.jackiewicz@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®