mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Michael Schmitz <schmitzmic@gmail.com>,
	Ondrej Zary <linux@rainbow-software.org>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 6/6] atari_scsi: Reset DMA during bus reset only under ST-DMA lock
Date: Sun, 15 Jan 2017 18:50:57 -0500 (EST)	[thread overview]
Message-ID: <89cbf4e7bb8924af18ad6ae4c3bea2de8c490f7a.1484523085.git.fthain@telegraphics.com.au> (raw)
In-Reply-To: <cover.1484523085.git.fthain@telegraphics.com.au>

The atari_scsi driver should not access Falcon DMA chip registers
unless it has acquired exclusive access to that chip. If the driver
doesn't have exclusive access then there's no need for a DMA reset
as there are no scsi commands in progress.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
 drivers/scsi/atari_scsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c
index b2ffab65..f792420 100644
--- a/drivers/scsi/atari_scsi.c
+++ b/drivers/scsi/atari_scsi.c
@@ -682,7 +682,8 @@ static int atari_scsi_bus_reset(struct scsi_cmnd *cmd)
 	if (IS_A_TT()) {
 		tt_scsi_dma.dma_ctrl = 0;
 	} else {
-		st_dma.dma_mode_status = 0x90;
+		if (stdma_is_locked_by(scsi_falcon_intr))
+			st_dma.dma_mode_status = 0x90;
 		atari_dma_active = 0;
 		atari_dma_orig_addr = NULL;
 	}
-- 
2.10.2

  parent reply	other threads:[~2017-01-15 23:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-15 23:50 [PATCH 0/6] ncr5380: Miscellaneous minor patches Finn Thain
2017-01-15 23:50 ` [PATCH 1/6] ncr5380: Shorten host info string by removing unused option macros Finn Thain
2017-01-15 23:50 ` [PATCH 5/6] ncr5380: Improve target selection robustness Finn Thain
2017-01-15 23:50 ` [PATCH 4/6] ncr5380: Resolve various static checker warnings Finn Thain
2017-01-15 23:50 ` [PATCH 2/6] ncr5380: Clean up dead code and redundant macro usage Finn Thain
2017-01-15 23:50 ` [PATCH 3/6] ncr5380: Reduce #include files Finn Thain
2017-01-15 23:50 ` Finn Thain [this message]
2017-01-25 23:25 ` [PATCH 0/6] ncr5380: Miscellaneous minor patches Martin K. Petersen
2017-01-26  3:00   ` Michael Schmitz
2017-01-26  3:31     ` Martin K. Petersen
2017-01-28 21:44 ` Ondrej Zary
2017-01-29  1:05   ` Finn Thain
2017-01-30 21:52     ` Ondrej Zary
2017-01-31  1:31       ` g_NCR5380 PDMA, was " Finn Thain
2017-02-16 22:18         ` Ondrej Zary
2017-02-17 22:38           ` Finn Thain
2017-02-18 11:10             ` Ondrej Zary
2017-02-18 23:27               ` Finn Thain
2017-02-19 11:19                 ` Ondrej Zary
2017-02-19 23:19                   ` Finn Thain
2017-01-30  3:15 ` Michael Schmitz
2017-01-30  4:06   ` Finn Thain
2017-02-01  2:40 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89cbf4e7bb8924af18ad6ae4c3bea2de8c490f7a.1484523085.git.fthain@telegraphics.com.au \
    --to=fthain@telegraphics.com.au \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=martin.petersen@oracle.com \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®