mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: socfpga: stratix10: use new parent data scheme
Date: Tue, 10 Mar 2020 00:55:27 -0500	[thread overview]
Message-ID: <8a863030-bf95-90c6-9f8b-2a55ad46cb03@kernel.org> (raw)
In-Reply-To: <158379285687.149997.12928033376494434912@swboyd.mtv.corp.google.com>



On 3/9/20 5:27 PM, Stephen Boyd wrote:
> Quoting Dinh Nguyen (2020-02-28 12:36:11)
>> +
>> +static const struct clk_parent_data mpu_free_mux[] = {
>> +       { .name = "main_mpu_base_clk", },
>> +       { .name = "peri_mpu_base_clk", },
>> +       { .name = "osc1", },
>> +       { .name = "cb-intosc-hs-div2-clk", },
>> +       { .name = "f2s-free-clk", },
>> +};
> 
> While this changes everything to use the new way it doesn't actually
> migrate anything over to using direct pointers or the .fw_name field.
> What's going on?
> 

Sorry about that. I am using direct pointers to the new parent data here:

in drivers/clk/socfpga/clk-periph-s10.c

-       init.parent_names = parent_names;
+       init.parent_names = NULL;
+       init.parent_data = clks->parent_data;

The driver seems to work fine without having to add .fw_name.

Dinh


  reply	other threads:[~2020-03-10  5:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-28 20:36 Dinh Nguyen
2020-03-09 22:27 ` Stephen Boyd
2020-03-10  5:55   ` Dinh Nguyen [this message]
2020-03-16 16:01     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a863030-bf95-90c6-9f8b-2a55ad46cb03@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®