From: Finn Thain <fthain@telegraphics.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Vivier <lvivier@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 04/12] m68k/mac: Place ISM IOP in bypass mode
Date: Sat, 31 Mar 2018 21:41:04 -0400 (EDT) [thread overview]
Message-ID: <8b6687388074cd4be70b625f874292cd062e0b04.1522546571.git.fthain@telegraphics.com.au> (raw)
In-Reply-To: <cover.1522546571.git.fthain@telegraphics.com.au>
Some Mac models have an IOP for offloading floppy disk IO. Linux once
had a driver for that but it got removed in commit b21a323710e7
("[PATCH] remove the broken BLK_DEV_SWIM_IOP driver").
Put the ISM IOP into bypass mode so that the existing 'swim_mod' driver
can access the controller directly. Use the appropriate macros for the
flag bits.
Cc: Laurent Vivier <lvivier@redhat.com>
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
arch/m68k/mac/iop.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/m68k/mac/iop.c b/arch/m68k/mac/iop.c
index 9bfa17015768..7864dcca5891 100644
--- a/arch/m68k/mac/iop.c
+++ b/arch/m68k/mac/iop.c
@@ -234,6 +234,7 @@ static struct iop_msg *iop_get_unused_msg(void)
* is to find and initialize the IOPs early in the boot sequence, so that
* the serial IOP can be placed into bypass mode _before_ we try to
* initialize the serial console.
+ * The ISM IOP is put into bypass mode for compatibility with the swim driver.
*/
void __init iop_preinit(void)
@@ -244,7 +245,8 @@ void __init iop_preinit(void)
} else {
iop_base[IOP_NUM_SCC] = (struct mac_iop *) SCC_IOP_BASE_QUADRA;
}
- iop_base[IOP_NUM_SCC]->status_ctrl = 0x87;
+ iop_base[IOP_NUM_SCC]->status_ctrl = IOP_BYPASS | IOP_AUTOINC |
+ IOP_RUN | IOP_DMAINACTIVE;
iop_scc_present = 1;
} else {
iop_base[IOP_NUM_SCC] = NULL;
@@ -256,7 +258,8 @@ void __init iop_preinit(void)
} else {
iop_base[IOP_NUM_ISM] = (struct mac_iop *) ISM_IOP_BASE_QUADRA;
}
- iop_base[IOP_NUM_ISM]->status_ctrl = 0;
+ iop_base[IOP_NUM_ISM]->status_ctrl = IOP_BYPASS | IOP_AUTOINC |
+ IOP_RUN | IOP_DMAINACTIVE;
iop_ism_present = 1;
} else {
iop_base[IOP_NUM_ISM] = NULL;
--
2.16.1
next prev parent reply other threads:[~2018-04-01 1:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 1:41 [PATCH 00/12] SWIM driver fixes Finn Thain
2018-04-01 1:41 ` [PATCH 01/12] m68k/mac: Revisit floppy disc controller base addresses Finn Thain
2018-04-01 1:41 ` [PATCH 02/12] m68k/mac: Fix SWIM memory resource end address Finn Thain
2018-04-09 12:51 ` Geert Uytterhoeven
2018-04-01 1:41 ` Finn Thain [this message]
2018-04-01 1:41 ` [PATCH 03/12] m68k/mac: Don't remap SWIM MMIO region Finn Thain
2018-04-09 12:54 ` Geert Uytterhoeven
2018-04-09 15:17 ` Luc Van Oostenryck
2018-04-10 1:35 ` Finn Thain
2018-04-10 2:38 ` Michael Schmitz
2018-04-01 1:41 ` [PATCH 06/12] block/swim: Fix array bounds check Finn Thain
2018-04-09 13:08 ` Geert Uytterhoeven
2018-04-10 1:10 ` Finn Thain
2018-04-01 1:41 ` [PATCH 07/12] block/swim: Remove extra put_disk() call from error path Finn Thain
2018-04-09 13:11 ` Geert Uytterhoeven
2018-04-01 1:41 ` [PATCH 09/12] block/swim: Rename macros to avoid inconsistent inverted logic Finn Thain
2018-04-01 1:41 ` [PATCH 05/12] block/swim: Use HEDSEL bit in ISM mode register Finn Thain
2018-04-01 1:41 ` [PATCH 08/12] block/swim: Don't log an error message for an invalid ioctl Finn Thain
2018-04-09 13:14 ` Geert Uytterhoeven
2018-04-10 1:27 ` Finn Thain
2018-04-01 1:41 ` [PATCH 10/12] block/swim: Check drive type Finn Thain
2018-04-01 1:41 ` [PATCH 12/12] block/swim: Select appropriate drive on device open Finn Thain
2018-04-01 1:41 ` [PATCH 11/12] block/swim: Fix IO error at end of medium Finn Thain
2018-04-03 19:07 ` [PATCH 00/12] SWIM driver fixes Laurent Vivier
2018-04-03 22:53 ` Finn Thain
2018-04-03 23:32 ` Jens Axboe
2018-04-03 23:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b6687388074cd4be70b625f874292cd062e0b04.1522546571.git.fthain@telegraphics.com.au \
--to=fthain@telegraphics.com.au \
--cc=axboe@kernel.dk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=lvivier@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®