From: "M K, Muralidhara" <muralimk@amd.com>
To: Muralidhara M K <muralidhara.mk@amd.com>, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] platform/x86/amd/hsmp: Harden ACPI probe, metric DRAM, and socket teardown
Date: Tue, 16 Jun 2026 13:58:53 +0530 [thread overview]
Message-ID: <8b8ab5dd-3f9c-4f1e-b853-97c381c885da@amd.com> (raw)
In-Reply-To: <20260613191755.2358969-1-muralidhara.mk@amd.com>
Hi Ilpo,
Could you please check and review.
On 6/14/2026 12:47 AM, Muralidhara M K wrote:
> This series tightens concurrency and lifetime management in the ACPI-backed
> AMD HSMP platform path so probe/remove races cannot corrupt global probe state,
> leak metric-table DRAM mappings, or tear down shared resources while readers
> might still be active.
>
> Patch 1 introduces a dedicated probe mutex around ACPI probe, remove, and
> init_acpi(), replacing ad-hoc synchronization on the global is_probed handshake.
> lockdep_assert_held() documents the locking contract for init_acpi().
>
> Patch 2 switches metric table DRAM from devm_ioremap() to ioremap() with
> explicit init/teardown helpers, and embeds a per-socket mutex for metric reads.
> The legacy platform driver wires the same helpers so non-ACPI builds stay
> consistent.
>
> Patch 3 replaces the global is_probed flag with miscdevice registration state,
> refcounts ACPI socket platform devices with kref, and runs coordinated release
> on the final put: misc deregistration when appropriate, metric unmap, and socket
> array free. Socket storage uses kcalloc() with careful failure cleanup before
> any kref is published.
>
> Muralidhara M K (3):
> platform/x86/amd/hsmp: Serialize ACPI HSMP is_probed with a probe
> mutex
> platform/x86/amd/hsmp: Add explicit metric DRAM mapping and per-socket
> mutexes
> platform/x86/amd/hsmp: ACPI HSMP refcounted sockets and coordinated
> release
>
> drivers/platform/x86/amd/hsmp/acpi.c | 87 +++++++++++++++++++++++-----
> drivers/platform/x86/amd/hsmp/hsmp.c | 38 +++++++++++-
> drivers/platform/x86/amd/hsmp/hsmp.h | 9 ++-
> drivers/platform/x86/amd/hsmp/plat.c | 3 +
> 4 files changed, 119 insertions(+), 18 deletions(-)
>
next prev parent reply other threads:[~2026-06-16 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 19:17 Muralidhara M K
2026-06-13 19:17 ` [PATCH 1/3] platform/x86/amd/hsmp: Serialize ACPI HSMP is_probed with a probe mutex Muralidhara M K
2026-06-13 19:17 ` [PATCH 2/3] platform/x86/amd/hsmp: Add explicit metric DRAM mapping and per-socket mutexes Muralidhara M K
2026-06-13 19:17 ` [PATCH 3/3] platform/x86/amd/hsmp: ACPI HSMP refcounted sockets and coordinated release Muralidhara M K
2026-06-16 8:28 ` M K, Muralidhara [this message]
2026-06-16 12:19 ` [PATCH 0/3] platform/x86/amd/hsmp: Harden ACPI probe, metric DRAM, and socket teardown Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b8ab5dd-3f9c-4f1e-b853-97c381c885da@amd.com \
--to=muralimk@amd.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muralidhara.mk@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®