From: Mike Frysinger <vapier.adi@gmail.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, Robin Getz <rgetz@blackfin.uclinux.org>
Subject: Re: [PATCH] module: use MODULE_SYMBOL_PREFIX with module_layout
Date: Fri, 19 Jun 2009 14:29:20 -0400 [thread overview]
Message-ID: <8bd0f97a0906191129kc1b08cdr3373d972f1e710f0@mail.gmail.com> (raw)
In-Reply-To: <200906192332.43672.rusty@rustcorp.com.au>
On Fri, Jun 19, 2009 at 10:02, Rusty Russell wrote:
> On Fri, 19 Jun 2009 05:19:22 pm Mike Frysinger wrote:
>> The check_modstruct_version() needs to look up the symbol "module_layout"
>> in the kernel, but it does so literally and not by a C identifier. The
>> trouble is that it does not include a symbol prefix for those ports that
>> need it (like the Blackfin and H8300 port). So make sure we tack on the
>> MODULE_SYMBOL_PREFIX define to the front of it.
>
> Thanks, applied. I'm surprised this took so long to find.
well, technically i first noticed on 2007-10-24, but the fix that went
in internally sucked and people forgot about it ;)
-mike
next prev parent reply other threads:[~2009-06-19 18:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 15:24 module version magic and arches with symbol prefixes Mike Frysinger
2009-06-19 5:38 ` Rusty Russell
2009-06-19 7:49 ` [PATCH] module: use MODULE_SYMBOL_PREFIX with module_layout Mike Frysinger
2009-06-19 14:02 ` Rusty Russell
2009-06-19 18:29 ` Mike Frysinger [this message]
2009-06-19 12:54 ` module version magic and arches with symbol prefixes Robin Getz
2009-06-19 13:14 ` Mike Frysinger
2009-06-19 17:07 ` Robin Getz
2009-06-19 18:32 ` Mike Frysinger
2009-06-23 7:07 ` Rusty Russell
2009-06-29 12:07 ` Robin Getz
2009-07-23 14:12 [PATCH] module: use MODULE_SYMBOL_PREFIX with module_layout Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0906191129kc1b08cdr3373d972f1e710f0@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgetz@blackfin.uclinux.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®