From: Mike Frysinger <vapier.adi@gmail.com>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Felipe Balbi <felipe.balbi@nokia.com>,
"stable@kernel.org" <stable@kernel.org>,
"stable-review@kernel.org" <stable-review@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sonic Zhang <sonic.zhang@analog.com>
Subject: Re: [PATCH] USB: musb: fix build error introduced by isoc change
Date: Mon, 8 Mar 2010 11:41:26 -0500 [thread overview]
Message-ID: <8bd0f97a1003080841p7e425822w5eeb31b97cff0baf@mail.gmail.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB0321623721@dbde02.ent.ti.com>
On Mon, Mar 8, 2010 at 11:31, Gadiyar, Anand wrote:
> Mike Frysinger wrote:
>> From: Sonic Zhang <sonic.zhang@analog.com>
>>
>> The recent commit "usb: musb: Fix for isochronous IN transfer" (f82a689fa)
>> seems to have been against an older kernel version. It uses the old style
>> naming of variables. Unfortunately, this breaks building for most MUSB
>> users out there since "bDesiredMode" has been renamed to "desired_mode".
>>
>
> Looks like this code is under a "#ifdef USE_MODE1" check; that's why
> we did not find this during regular builds.
ah, ok. Felipe should tweak the changelog to mention this when merging ;)
> Felipe's upcoming patches would make this code redundant anyway.
>
> Till then, we might as well fix it.
right ... this at least should go into 2.6.33.x
-mike
next prev parent reply other threads:[~2010-03-08 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 16:26 Mike Frysinger
2010-03-08 16:31 ` Gadiyar, Anand
2010-03-08 16:41 ` Mike Frysinger [this message]
2010-03-08 18:34 ` Felipe Balbi
2010-03-11 12:43 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a1003080841p7e425822w5eeb31b97cff0baf@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sonic.zhang@analog.com \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®